Hi Adam, One correction: FINERACT-2899 (#6584) is withdrawn. We only saw the charge remain waived on a waiver that had lost its charge link after a reverse-replay. That is the bug FINERACT-2895 (#6575) fixes. I've closed the PR, but I can't close or delete the ticket.
Regarding the rest: PR#6575 and PR#6578 are green. PR#6581: spotless never ran. Maven Central returned 429 Too Many Requests while downloading durian-swt.os. PR#6580: two E2E scenarios in shard 15 timed out waiting for a business event. The PR only changes access modifiers, so the timeouts don't look related. Could someone re-run the failed PRs? And, who could review the four? Best regards, Piotr Wargulak SolDevelo On Mon, Oct 5, 2026 at 4:22 PM Ádám Sághy <[email protected]> wrote: > Hi Piotr, > > Thank you very much for raising these issues and the fixing PRs. > > Regards, > Adam S > > On Oct 5, 2026, at 2:08 PM, Piotr Wargulak via dev < > [email protected]> wrote: > > Hi all, > > We've been adapting Fineract for a client's lending products, mostly > progressive loans, charges, and undo/replay functionality. Along the way we > found a few problems that don't look specific to our setup. > > We fixed them on our fork and opened pull requests upstream: > - FINERACT-2895 (#6575): after a reverse-replay, a waiver on the same day > loses its link to the charge, so the waiver can't be undone afterwards. > - FINERACT-2896 (#6578): adds an optional transactionDate to > ?command=waive, so a waiver can be dated. > - FINERACT-2897 (#6580): makes processPaymentAllocation and Balances > protected, so the advanced allocation processor can be extended instead of > copied. > - FINERACT-2898 (#6581): makes the order of charges that fall due on the > same day deterministic. > - FINERACT-2899 (#6584): adjust now rejects a WAIVE_CHARGES transaction > and points to undo-waive. Today it returns 200 but leaves the charge waived. > > We'd appreciate it if someone could approve these and let us know if any > of them should be handled differently. > > Best regards, > Piotr Wargulak > SolDevelo > > > *SolDevelo* Sp. z o.o. [LLC] / www.soldevelo.com > Al. Zwycięstwa 96/98 > <https://www.google.com/maps/search/Al.+Zwyci%C4%99stwa+96%2F98?entry=gmail&source=g>, > 81-451, Gdynia, Poland > Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41 > > > -- * SolDevelo* Sp. z o.o. [LLC] / www.soldevelo.com <http://www.soldevelo.com> Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
