Hi all,

Following up on my mail of 13 Oct, sorry this took longer than the date I
gave. I didn't hear otherwise, so I've filed the GLIM part as FINERACT-3228:
https://issues.apache.org/jira/browse/FINERACT-3228

I'm working on the fix (validator rule, unit test and Feign integration
test) and will link the PR on the ticket. I've only taken the GLIM part;
GSIM and the collection sheet stay with Tofunmi.

Thanks,
Shivaansh Pandey
GitHub: shivaansh0610-LUFFY


On Tue, Oct 13, 2026 at 11:47 AM Shivaansh Pandey <[email protected]>
wrote:

> Hi Tofunmi, James, all,
>
> I joined the list after Tofunmi's mail of September 12, so I can't
> reply to it directly. The thread is here:
> https://lists.apache.org/thread.html/3oy7fxpc7cjdn2osc6ppnr5ttss327g8
>
> Thanks for the write-up. I reproduced the GLIM part (#1) on current
> develop (f9c2fcdc1c, 1.16.0-SNAPSHOT, PostgreSQL), and it is narrower
> than "no working request shape":
>
> - POST /v1/loans with loanType "glim", isParentAccount true and
> totalLoan 10000 returns 200 with glimId 1.
> - The identical request without totalLoan returns 403
> error.msg.unknown.data.integrity.issue, and the backend log shows the
> not-null violation on glim_accounts.principal_amount.
> - GroupLoanIntegrationTest's GLIM tests (which send totalLoan) pass on
> PostgreSQL in CI at the same commit.
>
> So this looks like a missing validation rather than a Postgres
> incompatibility: the absent totalLoan reaches the glim_accounts insert
> as null, and the database error comes back as a generic 403. I have
> not tested MySQL or MariaDB.
>
> I searched Jira for GLIM, totalLoan, isParentAccount and glim_accounts
> and found no ticket for this (FINERACT-1279 is an unrelated 2020
> charge / linked-savings case).
>
> Proposal: I will take just the GLIM piece—implementing a rule in
> LoanApplicationValidator that returns a 400 specifying the missing
> `totalLoan`, along with tests. Tofunmi, you mentioned filing JIRA
> first: would you like to file the GLIM ticket, or shall I file it and
> link #376? If I don't hear otherwise by Friday, October 16, I will
> file it and link back. GSIM and the collection sheet stay with you.
>
> Thanks,
> Shivaansh Pandey
> GitHub: shivaansh0610-LUFFY
>

Reply via email to