Hi Sanvi,

I'd suggest opening a dependent PR rather than waiting for the parent PR to
be merged.

You can target the branch associated with PR #6736 and clearly mention the
dependency in your PR description, linking the parent PR and marking it as
dependent on its merge.

Once #6736 is merged, you can rebase your changes onto the latest develop
branch and update the PR target accordingly.

Since you've already implemented the changes and verified them with
integration tests, I think it's worth getting the contribution out for
early review.

Thanks!
Sujan

On Sat, 21 Nov 2026 at 19:47, Sanvi Naik <[email protected]> wrote:

> Hi everyone,
>
> I'm working on FINERACT-3206, which addresses the issue where backdated
> savings deposits and withdrawals do not reverse subsequent accruals when
> pivot-date configuration is enabled.
>
> Chinmaya Samantara informed me that FINERACT-3206 is related to
> FINERACT-2994 (his PR #6736), which introduces the underlying savings
> accrual reversal logic.
>
> Following his suggestion, I've implemented the FINERACT-3206 changes on
> top of the changes in PR #6736. I've also added integration tests covering
> both backdated deposits and withdrawals with pivot-date configuration
> enabled. The PostgreSQL integration test workflow has passed.
>
> Since PR #6736 is still open and my changes depend on it, I'm unsure how
> best to proceed with submitting my contribution.
>
> Should I wait for PR #6736 to be merged before opening my PR, or should I
> open a dependent PR now? If I open one now, what would be the preferred way
> to handle the dependency and PR target branch?
>
> I'd appreciate your guidance on how to proceed.
>
> Thanks,
>
> Sanvi Abhijit Naik
>

Reply via email to