Hi Sujan, Thanks for clarifying. I initially thought my question might have been too straightforward, so I went ahead with the approach of opening the dependent PR against develop and mentioning the dependency in its description, rather than waiting for further discussion.
I hadn't realised that we should allow 72 hours for the community to respond before proceeding. I'll keep this in mind for future discussions. I'll leave PR #6998 as it is and rebase once #6736 is merged. Thanks, Sanvi On Sat, Nov 21, 2026 at 11:07 PM Sujan <[email protected]> wrote: > Hi Sanvi, > > Just a small clarification for future reference: when initiating a > discussion on the Apache Fineract dev mailing list, we generally need to > allow 72 hours for the community to respond before making a decision. > > That said, it's fine this time. You can leave the PR as it is for now and > wait for the dependent PR (#6736) to be merged. Once it's merged, rebase > your branch against "develop" and resolve any conflicts that arise. > > Thanks! > > On Sat, 21 Nov, 2026, 22:22 Sanvi Naik, <[email protected]> wrote: > >> Update: I went ahead and opened the PR directly against >> apache/fineract:develop based on PR #6736's branch, and noted the >> dependency in the description: < Pull requests · apache/fineract >> <https://github.com/apache/fineract/pull/6998> > >> >> On Sat, Nov 21, 2026 at 8:28 PM Sanvi Naik <[email protected]> >> wrote: >> >>> Thanks for the guidance. >>> >>> Just wanted to clarify one thing before opening the PR. Should I create >>> it against samchinmaya/fineract, targeting >>> FINERACT-2994-savings-undo-accruals, or should I open it in >>> apache/fineract itself? >>> >>> I want to make sure I am following the intended dependent PR workflow >>> correctly. >>> >>> On Sat, Nov 21, 2026 at 8:02 PM Sujan <[email protected]> wrote: >>> >>>> Hi Sanvi, >>>> >>>> I'd suggest opening a dependent PR rather than waiting for the parent >>>> PR to be merged. >>>> >>>> You can target the branch associated with PR #6736 and clearly mention >>>> the dependency in your PR description, linking the parent PR and marking it >>>> as dependent on its merge. >>>> >>>> Once #6736 is merged, you can rebase your changes onto the latest >>>> develop branch and update the PR target accordingly. >>>> >>>> Since you've already implemented the changes and verified them with >>>> integration tests, I think it's worth getting the contribution out for >>>> early review. >>>> >>>> Thanks! >>>> Sujan >>>> >>>> On Sat, 21 Nov 2026 at 19:47, Sanvi Naik <[email protected]> >>>> wrote: >>>> >>>>> Hi everyone, >>>>> >>>>> I'm working on FINERACT-3206, which addresses the issue where >>>>> backdated savings deposits and withdrawals do not reverse subsequent >>>>> accruals when pivot-date configuration is enabled. >>>>> >>>>> Chinmaya Samantara informed me that FINERACT-3206 is related to >>>>> FINERACT-2994 (his PR #6736), which introduces the underlying savings >>>>> accrual reversal logic. >>>>> >>>>> Following his suggestion, I've implemented the FINERACT-3206 changes >>>>> on top of the changes in PR #6736. I've also added integration tests >>>>> covering both backdated deposits and withdrawals with pivot-date >>>>> configuration enabled. The PostgreSQL integration test workflow has >>>>> passed. >>>>> >>>>> Since PR #6736 is still open and my changes depend on it, I'm unsure >>>>> how best to proceed with submitting my contribution. >>>>> >>>>> Should I wait for PR #6736 to be merged before opening my PR, or >>>>> should I open a dependent PR now? If I open one now, what would be the >>>>> preferred way to handle the dependency and PR target branch? >>>>> >>>>> I'd appreciate your guidance on how to proceed. >>>>> >>>>> Thanks, >>>>> >>>>> Sanvi Abhijit Naik >>>>> >>>>
