[jira] [Commented] (FINERACT-186) optimising the Post Interest For Savings batch job using pagination

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FINERACT-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344173#comment-15344173
 ] 

ASF GitHub Bot commented on FINERACT-186:
-----------------------------------------

Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/152#discussion_r68039658
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularServiceImpl.java
 ---
    @@ -30,47 +30,57 @@
     import 
org.apache.fineract.portfolio.savings.domain.SavingsAccountStatusType;
     import org.joda.time.LocalDate;
     import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.data.domain.Page;
    +import org.springframework.data.domain.PageRequest;
     import org.springframework.stereotype.Service;
     
     @Service
     public class SavingsSchedularServiceImpl implements 
SavingsSchedularService {
     
         private final SavingsAccountAssembler savingAccountAssembler;
         private final SavingsAccountWritePlatformService 
savingsAccountWritePlatformService;
    -    private final SavingsAccountRepository savingAccountRepository;
         private final SavingsAccountReadPlatformService 
savingAccountReadPlatformService;
    +    private final SavingsAccountRepository savingsAccountRepository;
     
         @Autowired
         public SavingsSchedularServiceImpl(final SavingsAccountAssembler 
savingAccountAssembler,
                 final SavingsAccountWritePlatformService 
savingsAccountWritePlatformService,
    -            final SavingsAccountRepository savingAccountRepository,
    -            final SavingsAccountReadPlatformService 
savingAccountReadPlatformService) {
    +            final SavingsAccountReadPlatformService 
savingAccountReadPlatformService,
    +            final SavingsAccountRepository savingsAccountRepository) {
             this.savingAccountAssembler = savingAccountAssembler;
             this.savingsAccountWritePlatformService = 
savingsAccountWritePlatformService;
    -        this.savingAccountRepository = savingAccountRepository;
             this.savingAccountReadPlatformService = 
savingAccountReadPlatformService;
    +        this.savingsAccountRepository = savingsAccountRepository;
         }
     
         @CronTarget(jobName = JobName.POST_INTEREST_FOR_SAVINGS)
         @Override
         public void postInterestForAccounts() throws JobExecutionException {
    -        final List<SavingsAccount> savingsAccounts = 
this.savingAccountRepository.findSavingAccountByStatus(SavingsAccountStatusType.ACTIVE
    -                .getValue());
    +        int offSet = 0;
    --- End diff --
    
    Can you rename offSet to page. 


> optimising the Post Interest For Savings batch job using pagination
> -------------------------------------------------------------------
>
>                 Key: FINERACT-186
>                 URL: https://issues.apache.org/jira/browse/FINERACT-186
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: venkat Ganesh
>            Assignee: Markus Geiss
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)