[ 
https://issues.apache.org/jira/browse/FINERACT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798195#comment-15798195
 ] 

Myrle Krantz commented on FINERACT-357:
---------------------------------------

I strongly recommend splitting this ticket so the items are easier to work on 
and discuss separately.

1.) It is possible to create a maven artifact for a war file.  But do any of 
our users need this from us?  The way it is now is not creating an obstacle to 
reviews, so I'd wait for the request from our users.
2.) I agree with [~nazeer1100126] that providing details in the README is 
sufficient.  What Roman says about lowering the hurdles for reviewers is 
important, but we also need to keep effort in concordance with benefit.  Should 
we choose to do this point anyways, a possible technical solution is to create 
a gradle composite build at the top level.

> Address the review comments for 0.6.0-incubating release
> --------------------------------------------------------
>
>                 Key: FINERACT-357
>                 URL: https://issues.apache.org/jira/browse/FINERACT-357
>             Project: Apache Fineract
>          Issue Type: Task
>          Components: User Management
>            Reporter: Shaik Nazeer Hussain
>            Assignee: Shaik Nazeer Hussain
>
> As part of 0.5.0-incubating release, we got the following review comments 
> from IPMC members which should be addressed for 0.6.0-incubating release.
> 1) Maven repo should be included in place of war file for the next release
> 2) Gradle should be integrated in the top level directory. Currently it is 
> integrated with fineract-provider. (RAT issue)
> 3) Including License and License.md will confuse the people
> 4) The LICENSE maye be missing a license for jquery
> 5) Remove the list of software included in the binary release from the source 
> release LICENSE file. It’s fine to have two different license files
> 6) The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in 
> the top level, however the LICENSE and NOTICE file is inside the war and look 
> correct
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CE4A4287E-8A78-4A61-9666-0F111BFA9D7C%40classsoftware.com%3E
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to