[ 
https://issues.apache.org/jira/browse/FINERACT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820488#comment-15820488
 ] 

Shaik Nazeer Hussain commented on FINERACT-357:
-----------------------------------------------

The following review comments are addressed as part of 0.6.0-incubating 
release. I am closing this issue and creating two separate issues to address 
remaining two review comments. 

3) Including License and License.md will confuse the people
4) The LICENSE maye be missing a license for jquery
5) Remove the list of software included in the binary release from the source 
release LICENSE file. It’s fine to have two different license files
6) The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in the 
top level, however the LICENSE and NOTICE file is inside the war and look 
correct

> Address the review comments for 0.6.0-incubating release
> --------------------------------------------------------
>
>                 Key: FINERACT-357
>                 URL: https://issues.apache.org/jira/browse/FINERACT-357
>             Project: Apache Fineract
>          Issue Type: Task
>          Components: User Management
>            Reporter: Shaik Nazeer Hussain
>            Assignee: Shaik Nazeer Hussain
>
> As part of 0.5.0-incubating release, we got the following review comments 
> from IPMC members which should be addressed for 0.6.0-incubating release.
> 1) Maven repo should be included in place of war file for the next release
> 2) Gradle should be integrated in the top level directory. Currently it is 
> integrated with fineract-provider. (RAT issue)
> 3) Including License and License.md will confuse the people
> 4) The LICENSE maye be missing a license for jquery
> 5) Remove the list of software included in the binary release from the source 
> release LICENSE file. It’s fine to have two different license files
> 6) The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in 
> the top level, however the LICENSE and NOTICE file is inside the war and look 
> correct
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CE4A4287E-8A78-4A61-9666-0F111BFA9D7C%40classsoftware.com%3E
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to