Hi All,

REMINDER: Please VOTE on the Apache Flagon 2.1.0 Release.

Thanks,

Josh

> On Feb 14, 2020, at 10:33 AM, Rob Foley <[email protected]> wrote:
> 
> A bit late, but +1:
> 
> [x] Build and Unit Tests Pass
> [x] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release
> Packages
> [x] Signatures and Hashes Match Keys
> [x] CHANGELOG included with release distribution
> 
> On Mon, Feb 10, 2020 at 9:14 PM Joshua Poore <[email protected]> wrote:
> 
>> pushed updated webpack.config.js that includes ALv2 header
>> 
>>> On Feb 10, 2020, at 7:34 PM, Joshua Poore <[email protected]>
>> wrote:
>>> 
>>> Disregard. You’re right. webpack config is .js. Missed that.
>>> 
>>> You see any issues with our disclaimer given that the webpack config
>> doesn’t have a header?
>>> 
>>> Joshua Poore
>>> 
>>> 
>>>> On Feb 10, 2020, at 7:32 PM, Joshua Poore <[email protected]>
>> wrote:
>>>> 
>>>> Hi Dave,
>>>> 
>>>> Thanks for identifying! I thought comments aren’t supported in JSON.
>> There are custom libs for doing that, but I doubt node and web pack can
>> call them.
>>>> 
>>>> If you can point me to an example, I’ll get it in there.
>>>> 
>>>> Joshua Poore
>>>> 
>>>> 
>>>>>>> On Feb 10, 2020, at 5:03 PM, David Meikle <[email protected]> wrote:
>>>>>>> On Fri, 7 Feb 2020 at 23:12, Joshua Poore <[email protected]>
>> wrote:
>>>>>>> Hi Folks,
>>>>>>> Please VOTE on the Apache Flagon 2.1.0 Release Candidate 01
>>>>>>> Source Release Artifacts:
>>>>>>> 
>> https://dist.apache.org/repos/dist/dev/incubator/flagon/apache-flagon-useralejs-incubating-2.1.0-RC-01/
>>>>>>> <
>>>>>>> 
>> https://dist.apache.org/repos/dist/dev/incubator/flagon/apache-flagon-useralejs-incubating-2.1.0-RC-01/
>>>>>>> Vote will be open for 72 hours. Please VOTE as follows:
>>>>>>> [ ] +1, let's get it released!!!
>>>>>>> [ ] +/-0, fine, but consider to fix few issues before...
>>>>>>> [ ] -1, nope, because... (and please explain why)
>>>>> +1 (binding) : Performed the check list provided on the source release
>>>>> package.
>>>>> There are some files, like the webpack.config.js, flagged by Apache RAT
>>>>> that we could put an AL header on. Not a deal breaker, but worth
>>>>> considering.
>>>>> Cheers,
>>>>> Dave
>>> 
>> 
>> 

Reply via email to