poorejc commented on code in PR #350:
URL: https://github.com/apache/flagon-useralejs/pull/350#discussion_r1182016251
##########
example/index.js:
##########
@@ -34,28 +34,26 @@ window.userale.options({
* Note that for surgical filters, you may need to clear or reset back to a
global filter callback
* the same is true for the 'map' API. See examples below:
*/
-window.userale.filter(function (log) {
- var type_array = ['mouseup', 'mouseover', 'mousedown', 'keydown',
'dblclick', 'blur', 'focus', 'input', 'wheel'];
- var logType_array = ['interval'];
- return !type_array.includes(log.type) &&
!logType_array.includes(log.logType);
+window.userale.addCallbacks({
+ filter(log) {
+ var type_array = ['mouseup', 'mouseover', 'mousedown', 'keydown',
'dblclick', 'blur', 'focus', 'input', 'wheel'];
+ var logType_array = ['interval'];
+ return !type_array.includes(log.type) &&
!logType_array.includes(log.logType);
+ }
});
/**Log Mapping API
*
* the 'map' API allows you to add or modify new fields to your logs
* this example works with the "Click Me!" button at the top of index.html
*/
-document.addEventListener('click', function(e){
- if (e.target.innerHTML === 'Click Me!') {
- window.userale.map(function (log) {
+window.userale.addCallbacks({
+ map(log, e) {
+ if(e && e.type === 'click' && e.target.innerHTML === 'Click Me!') {
Review Comment:
sorry for the delay in jumping in, but I fully support these changes. I
realize that this could be a breaking change down the line, but this is long
overdue and eventually this kind of thing needs to happen. Fully agree with
@UncleGedd's do-outs. After that's done, I see no issues moving this to test
and then merging with Master if unit and some integration tests pass. If
@UncleGedd and/or @brucearctor want to merge with test, I can help run an
integration test this weekend, but definitely don't want to be a blocker if no
one else sees any!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
