I would prefer we don't mass merge from develop. If you have a pending change for 4.9.1, check it directly into Release4.9 branch. Then merge it to develop or we'll do it at the end.
On 2/14/13 10:46 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > We'll have to carefully choose what we'll merge from the develop branch into > the 4.9.1, as reminder, those tests fails : > > FP 11.1.102.63 : > > LangPacks/Japanese/tests/... > > components/Charts/Bubble/Properties/BubbleProperties > BubbleSeries_multipleAxes_disabledDays > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds1 > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds2 > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds3 > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds4 > gumbo/components/Grid/Methods/Grid_Methods_basic > Grid_Methods_getColumnBounds1 > gumbo/components/Grid/Methods/Grid_Methods_basic > Grid_Methods_getItemRendererAt1 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation2 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation3 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation4 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation5 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation6 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_scrollPosition3 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_scrollPosition5 > gumbo/components/List/events/ItemRendRET_event_tester > RendRET_List_keyboard_navigation2 > gumbo/components/List/events/ItemRendRET_event_tester > RendRET_List_keyboard_navigation6 > > > FP 11.5.502.110 : > > LangPacks/Japanese/tests/... > > components/Charts/Bubble/Properties/BubbleProperties > BubbleSeries_multipleAxes_disabledDays > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds1 > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds2 > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds3 > gumbo/components/Grid/Methods/Grid_Methods_basic Grid_Methods_getCellBounds4 > gumbo/components/Grid/Methods/Grid_Methods_basic > Grid_Methods_getColumnBounds1 > gumbo/components/Grid/Methods/Grid_Methods_basic > Grid_Methods_getItemRendererAt1 > gumbo/components/Image/styles/Image_styles_smoothingQuality > Image_Scale_stretch_smoothingQuality_high > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation2 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation3 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation4 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation5 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_keyboard_navigation6 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_scrollPosition3 > gumbo/components/List/events/ItemRendRETLabel_event_tester > RendRETLabel_List_scrollPosition5 > gumbo/components/List/events/ItemRendRET_event_tester > RendRET_List_keyboard_navigation2 > gumbo/components/List/events/ItemRendRET_event_tester > RendRET_List_keyboard_navigation6 > spark/core/fxg/properties/fxgtemplate_tester filters_filters_blend > spark/core/fxg/properties/fxgtemplate_tester scale9_bitmapgraphic_scale9 > spark/core/fxg/properties/fxgtemplate_tester > scale9_shape_bmpgraphic_scalegridgroup > > > I'm now sure for the new (as compared to the 4.9) failed tests > (gumbo/components/Grid and List) weren't introduced by the fix I did in > PopUpManagerImpl.as because I ran the tests with and without this change and > the failed tests were the same, so, I can commit it. > > > Any veto ? > > -Fred > > -----Message d'origine----- > From: Alex Harui > Sent: Thursday, February 14, 2013 7:19 PM > To: dev@flex.apache.org > Subject: RE: Apache Flex 4.9.1 > > We might want to add this to the list to be fixed: > > https://issues.apache.org/jira/browse/FLEX-33339 > > It turns out that I've never run the LangPacks tests and they fail > compilation which should stop the run but for some reason does not. > > I will look at them shortly after I fix a few other bugs. > > Alex Harui > Apache Flex Team > http://blogs.adobe.com/aharui > > >> -----Original Message----- >> From: Frédéric THOMAS [mailto:webdoubl...@hotmail.com] >> Sent: Thursday, February 14, 2013 8:15 AM >> To: dev@flex.apache.org >> Subject: Re: Apache Flex 4.9.1 >> >> Failures, building the trunk as is + other.locales and running the tests >> with : >> >> FP 11.1.102.63 : >> >> components/Charts/Bubble/Properties/BubbleProperties >> BubbleSeries_multipleAxes_disabledDays >> >> FP 11.5.502.110 : >> >> components/Charts/Bubble/Properties/BubbleProperties >> BubbleSeries_multipleAxes_disabledDays >> gumbo/components/Image/styles/Image_styles_smoothingQuality >> Image_Scale_stretch_smoothingQuality_high >> spark/core/fxg/properties/fxgtemplate_tester filters_filters_blend >> spark/core/fxg/properties/fxgtemplate_tester scale9_bitmapgraphic_scale9 >> spark/core/fxg/properties/fxgtemplate_tester >> scale9_shape_bmpgraphic_scalegridgroup >> >> -Fred >> >> -----Message d'origine----- >> From: Frédéric THOMAS >> Sent: Wednesday, February 13, 2013 11:12 PM >> To: dev@flex.apache.org >> Subject: Re: Apache Flex 4.9.1 >> >>> OK, we should fix broken tests, but it isn't as important as getting >> Release4.9 to pass all of its tests for this 4.9.1 release >> >> Ok, I just checked out the trunk and run the tests in en_US >> >>> Weren't your issues bad tests due to localization for fr_FR? I'm >>> pretty >> sure I got clean runs for en_US >> >> No, it was with en_US and FP 11.4 >> >>> Don't know. Have you determined what needs to change? If not, I will >>> see if >> those tests pass for me on tonight's run and investigate. >> >> I only know removing the font make the japanese text to be rendered. >> >> >> -----Message d'origine----- >> From: Alex Harui >> Sent: Wednesday, February 13, 2013 7:51 PM >> To: dev@flex.apache.org >> Subject: Re: Apache Flex 4.9.1 >> >> >> >> >> On 2/13/13 10:18 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: >> >>>> I don't know. Are you running the tests in the Release4.9 branch >> against >>> the code in Release4.9 or running tests from the develop branch? >>> >>> I run the tests against the develop branch. >> OK, we should fix broken tests, but it isn't as important as getting >> Release4.9 to pass all of its tests for this 4.9.1 release. >>> >>>> I'm pretty sure all tests passed before we shipped 4.9.0. >>> >>> No, remember, I posted on the fact some tests still failed before the >> 4.9 >>> release (nothing relative to LangPacks/Japanese/tests though). >> Weren't your issues bad tests due to localization for fr_FR? I'm pretty >> sure I got clean runs for en_US. >>> >>>> There may not be any japanese characters in OpenSans. We added a >> chinese >>> font for mobile testing (Assets/Fonts/Droid/DroidSansFallback.ttf). It >> is >>> only in the develop branch right now. >>> >>> Well, so, what should I do with my LangPacks/Japanese/tests and the >>> OpenSans >>> ? >> Don't know. Have you determined what needs to change? If not, I will see >> if >> those tests pass for me on tonight's run and investigate. >>> >>> -Fred >> >> >> -- >> Alex Harui >> Flex SDK Team >> Adobe Systems, Inc. >> http://blogs.adobe.com/aharui > -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
