On Jan 15, 2015 12:26 PM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > > Om, > > I'm unable to judge the severity of the remaining issues. Are they > minor, medium or major, in terms of developers it's likely to affect. > And, do you know of any viable workarounds for the issues? > > Your answers will help me decide if we can go ahead with the release...
Do you have a list that I can quickly review? Thanks, Om > > Thanks, > > EdB > > > > On Thu, Jan 15, 2015 at 7:02 AM, OmPrakash Muppirala > <bigosma...@gmail.com> wrote: > > Alex, this fix seems reasonable to me. I will take a look at how the iOS > > and Android versions react to this change when I get a chance. Worst case, > > we can ship with a (minor) defect in the new skins. > > > > Thanks, > > Om > > On Jan 15, 2015 2:46 AM, "Alex Harui" <aha...@adobe.com> wrote: > > > >> I checked in a “workarouund”. It might have broken IOS and Android > >> versions of SpinnerLists. Someone who knows better should take a look. > >> > >> The key issues is that there has always been a default accentColor for all > >> of Flex, but SpinnerList was not using it until Om fixed it to get > >> accentColor for at least the IOS skins. > >> > >> I added a “useAccentColor” style and set it to false to have the > >> SpinnerListItemRenderer ignore the accentColor when selected. That way > >> the old behavior of ignoring accentColor can be preserved. IOS > >> SpinnerLists sets useAccentColor to true. > >> > >> For DateSpinner, I added some png.xml files for the chinese characters > >> based on 4.13.0. That enabled several tests to pass on 4.14.0. The rest > >> passed when I adjusted the DateSpinner’s ItemRenderer now that its base > >> item renderer is trying to think about accentColors. > >> > >> I may have limited time or no time to fix any more issues until Friday. > >> > >> -Alex > >> > >> On 1/14/15, 10:12 AM, "Alex Harui" <aha...@adobe.com> wrote: > >> > >> > > >> > > >> >On 1/14/15, 9:47 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > >> > > >> >>If it breaks tests, at this point I suggest we (you?) revert that > >> >>change on the 'release' branch. That way, it lives on to be fixed on > >> >>the develop branch, but we'll be a step closer to a passing test > >> >>suite. > >> > > >> >Well, I’m assuming that Om made the change so that the IOS and Android > >> >skins would look ‘right’. We could change the default skin to remain > >> >black when selected, or we can just say “sorry about backward > >> >compatibility, but we think it is nicer this way”. And you can change > >> >accentColor to get back to black. > >> > > >> >-Alex > >> > > >> > >> > > > > -- > Ix Multimedia Software > > Jan Luykenstraat 27 > 3521 VB Utrecht > > T. 06-51952295 > I. www.ixsoftware.nl
