> I’d have to dig into it, but yes, I think addDependency gets called quite > often before we start walking the tree. But once you asked the question, > it did occur to me that we do call into the resolving code during the > walk, but I don’t know if that also results in addDependency. Not sure I understood everything but I can't see any call before walking the tree to FlexJSProject.addDependency() which is the function used to fill the requires that are then wrote in PackageHeaderEmitter using FlexJSProject.getRequires(), is there a function supposed to store the library definitions before the walk ? Frédéric THOMAS > From: aha...@adobe.com > To: dev@flex.apache.org > Subject: Re: [FlexJS] Framework using externs (was: Setup Error) > Date: Mon, 24 Aug 2015 12:55:05 +0000 > > > > On 8/24/15, 2:21 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote: > > >Do you mean, the FlexJSProject.addDependency() should be called while the > >AST is generated for the libraries dependencies or maybe be a pass for > >collecting them as we do in the externc ? > > I’d have to dig into it, but yes, I think addDependency gets called quite > often before we start walking the tree. But once you asked the question, > it did occur to me that we do call into the resolving code during the > walk, but I don’t know if that also results in addDependency. > > -Alex >
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- Re: [FlexJS] Framework using externs (was: Setup Error) Michael Schmalle
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS
- Re: [FlexJS] Framework using externs (was: Setup Error) Alex Harui
- RE: [FlexJS] Framework using externs (was: Setup Error) Frédéric THOMAS