On 12/31/15, 4:55 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote:
>Hi Alex, > >1) The poms are all there ... so you should simply copy them. After all >that's all what maven does. Yeah, I (or some other volunteer) will eventually get around to doing that. >2) I didn't want to hard-code the ports as I wanted the thing to run on >the Apache build servers and you never know which port is being used by >another job/service/... so the server starts up, reports it's port and >passes that to the tests. OK, but each server seems to use a different port, so a whole range is needed. I'm wondering if there is a way to use only one port by re-using the same server for each test, or maybe having a flag to slow down the tests so the servers fully shut down before the next server spins up or whatever is needed so that the logic that picks a port chooses the same port each time. > >3) I don't know what Jgroups is used for ... it was always in the build. >I would assume that it's used for running BlazeDS in a cluster >environment. OK. Jgroups appears to be optional in the Ant scripts. If we use it, we should probably choose a later version that is Apache-compatible. The opt Ant scripts also seem to have options for building with WebSphere, WebLogic and Oracle. Do you know if Adobe releases had those? > >4) You are probably talking about the JMS API and not a real JMS. I guess >that in both cases the API should be identical as long as it's the same >API version. But as JMS hasn't changed that much I bet you would be safe, >but it would be even better if we all used the same. OK, can you switch Maven to a version that is Apache-compatible? > >I was thinking about refactoring these tests to become Integration-Tests >as I don't think a Unit Test should require a server to be started. With >this split-up the unit-tests on the azure would run and the >integration-tests could be run on the ASF build servers (Which should be >the main ones) > >Would it be ok for me to take your Ant scripts, add them to the 4.8.0 >branch and adjust the things that need to be changed? As soon as all is >working there, I would merge 4.8.0 back to develop (even if this is going >to be a quite forceful commit). OK, go for it. Good luck, -Alex