Additionally, the cloning results in extra objects that need to be garbage collected, which can hurt performance and make effects/animations look bad. Good call on avoiding it!
- Josh On Tue, Jul 18, 2017 at 8:23 AM, Alex Harui <aha...@adobe.com.invalid> wrote: > +1 to what Harbs said. > > Also, in FlexJS, we want very few if any custom events to bubble. > Bubbling was overused in regular Flex and was, IMO, a bad practice because > it breaks encapsulation. > > Bubbling was intended to allow an object in the DOM to monitor inputs to > its children without having to attach listeners to the entire tree. It > was not meant as a way for a component to shout to the world "Hey, I just > changed a property, does anybody care?" > > -Alex > > On 7/17/17, 11:05 PM, "Harbs" <harbs.li...@gmail.com> wrote: > > >event.clone() is wrong for FlexJS. It’s event.cloneEvent() > > > >There was other feedback on the dev list. That seemed to have been > >ignored. > > > >A lot of the rules fly in the face to current convention in the SDK. Some > >(such as returning from a constructor) are actually enforced by the > >compiler so the rule is not needed. I don’t have time right now to get > >involved in a long protracted discussion, but please don’t take the lack > >of input as consensus. > > > >Feel free to do what you want to SonarQube now, but don’t make any > >changes based on the reports. If anyone else takes an interest in it, > >please expect some rules to be changed. > > > >Thanks, > >Harbs > > > >> On Jul 18, 2017, at 8:50 AM, Justin Mclean <jus...@classsoftware.com> > >>wrote: > >> > >> Hi, > >> > >> So more than a week has gone by and I’ve received little feedback on > >>[1]. Given that I’ll gone ahead and implement the rules as discussed in > >>the document so people can see the changes. > >> > >> The new results are up: > >> - First off the header rules is overly strict and expects a copyright > >>line not just a header. ASF policy to not to have copyright lines so > >>this is a false positive. I’ll disable the rule. We have other means to > >>check headers. This will be fixed in the next run. > >> - The ASDocs rule is picking a lot of public methods and properties > >>that don’t have ASDocs. I think we should keep this to remind us at some > >>point it needs to be fixed / people can fix as they make edits. > >> - Is easier to see if issues that do need to be fixed. For instance I > >>can see that there are a couple of event.clone issues that are likely > >>bugs. > >> > >> Thanks, > >> Justin > >> > >> 1. > >>https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fcwiki.ap > >>ache.org%2Fconfluence%2Fdisplay%2FFLEX%2FSonar% > 2BCube%2BFlex%2BRules&data > >>=02%7C01%7C%7C9be74a7882374975005208d4cda30749% > 7Cfa7b1b5a7b34438794aed2c1 > >>78decee1%7C0%7C0%7C636359547464506542&sdata= > cPs4sqimu5YFG%2B08ymZNtb9HMWC > >>WFGixhtyGrP0burM%3D&reserved=0 > >><https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fcwiki.a > >>pache.org%2Fconfluence%2Fdisplay%2FFLEX%2FSonar% > 2BCube%2BFlex%2BRules&dat > >>a=02%7C01%7C%7C9be74a7882374975005208d4cda3 > 0749%7Cfa7b1b5a7b34438794aed2c > >>178decee1%7C0%7C0%7C636359547464506542&sdata= > cPs4sqimu5YFG%2B08ymZNtb9HMW > >>CWFGixhtyGrP0burM%3D&reserved=0> > > > >
