I just left things as open as possible as I recall. Thanks Harbs.

On 7/23/17, 6:06 AM, "Harbs" <harbs.li...@gmail.com> wrote:

>Agreed, but I think the defaults should match Flash between and HTML.
>
>He did not set stretch. Nothing was set. ³stretch² is the default css.
>
>> On Jul 23, 2017, at 12:23 PM, Alex Harui <aha...@adobe.com.INVALID>
>>wrote:
>> 
>> There doesn't have to be one TileLayout.  There can be
>> TileLayoutWithFlexStart, TileLayoutWithStretch, and
>> TileLayoutWithAlignContent with a property that allows you to set it.
>> 
>> Peter may remember why he chose "stretch".
>> 
>> -Alex
>> 
>> On 7/23/17, 1:28 AM, "Harbs" <harbs.li...@gmail.com> wrote:
>> 
>>> I just discovered something which is worth bringing up:
>>> 
>>> The default for css flex layouts is align-content: stretch This adds
>>> space between elements if the total height (or width) of the elements
>>>are
>>> less than the parent. I don¹t think that¹s an appropriate default for a
>>> tile layout. The layout should be packed from the top left and only add
>>> space if there is padding/margins in the itemRenderers.
>>> 
>>> I believe the correct default css is align-content: flex-start which
>>>has
>>> the behavior that I would expect from a tile layout.
>>> 
>>> Of course, it might be interesting to have a tile layout which offers
>>> different spacing options. That could be alternate layouts, or even
>>>beads
>>> attached to the layout beads.
>>> 
>>> I fixed this issue in my app by just adding some align-content:
>>> flex-start css to my TileLayout component. This works because I don¹t
>>> need swf rendering, but I think it¹s something that should be addressed
>>> in the TileLayout.
>>> 
>>> Let me checkŠ
>>> 
>>> I just (fixed and) ran ContainerTest, and the swf behavior is in fact
>>> different than the HTML behavior. I think we can classify this as a
>>>bug.
>>> I¹m committing this change.
>>> 
>>> FWIW, there¹s lots of other differences between the swf output and the
>>>JS
>>> output in ContainerTest. It¹s probably worth looking into the rest of
>>> those issues as wellŠ
>>> 
>>> Harbs
>> 
>

Reply via email to