I spent some time checking out the release. The line-ending problem is a non-issue. Prior releases are set up this way as well. The "release" target fixes up the line endings when building the binary kit. I think the main build does not so it doesn't inject changes into the sources in a repo.
What is a problem with the release is that the files do not appear to be UTF-8 encoded. Or at least, many non-ASCII characters are not quite right when the source package is viewed from a mac. Note that the CI server's nightly build doesn't seem to have this issue. I believe this is because the CI server has the environment variable: JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 One such file is: frameworks/tests/basicTests//spark/views/SortTests.mxml You can compare the U+5DDD entry. For me, on my mac it is not the expected character. That causes the checkintests to fail to compile. I didn't find any key source files that are wrong and could cause trouble for users, so we could just let it go. What do others think? -Alex On 11/12/17, 3:58 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote: >Hi, > >Ok I got it, but I don't fully understand how changing line endings for >files check outed for sdk repository could change final .tar.gz file. >Exact >this file has wrong line endings, or file after unpack have ? > >Thanks, Piotr > > >2017-11-12 12:48 GMT+01:00 Justin Mclean <jus...@classsoftware.com>: > >> Hi, >> >> > What do I need to do in build.xml script in order to fix that or your >> > suggestion is to take this file and do something with it ? >> >> I’ve not build on windows for several years so not 100% sure sorry. When >> building on OSX I’ve not run into the issue. >> >> It may actually be a git setting issue in that you are changing line >> endings to windows on checking out the repo. It’s the autocrlf setting I >> believe what do you have that set to? >> >> Thanks, >> Justin > > > > >-- > >Piotr Zarzycki > >Patreon: >*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C7984b33e692b4fdd4c4108d529c4a6c4 >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636460846965406066&sdata=c9l >IyBHyRDkL3Tq8SpifW4DyyIF9smsaEA4Aerrv%2Fzs%3D&reserved=0 ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C7984b33e692b4fdd4c4108d529c4a6c4 >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636460846965406066&sdata=c9l >IyBHyRDkL3Tq8SpifW4DyyIF9smsaEA4Aerrv%2Fzs%3D&reserved=0>*
