Massive +1 for switching to space indention. Makes the code render consistently across various viewers (e.g. Github UI, Apache infrastructure, IDEs).
2015-03-18 1:29 GMT+01:00 Fabian Hueske <fhue...@gmail.com>: > Touching every file of the code would also be a good opportunity to switch > from tab to space indention. > So if we enforce a strict style, we could also address this issue which > causes discussions every now and then. > > 2015-03-16 21:53 GMT+01:00 Aljoscha Krettek <aljos...@apache.org>: > > > No, but I don't know whether that's possible. > > > > The style guide prescribes, for example, this: > > > > def foo( > > a: Int, > > b: String, > > c: String) > > > > for methods with long parameter lists while a lot of people do this: > > > > def foo(a: Int, > > b: String, > > c: String) > > > > (IntelliJ also does this). > > > > The scalastyle rules I added supposedly check for the official scala > > guide style but they allow both styles of methods. > > > > On Mon, Mar 16, 2015 at 5:37 PM, Till Rohrmann <trohrm...@apache.org> > > wrote: > > > Do we already enforce the official Scala style guide strictly? > > > > > > On Mon, Mar 16, 2015 at 4:57 PM, Aljoscha Krettek <aljos...@apache.org > > > > > wrote: > > > > > >> I'm already always sticking to the official Scala style guide, with > the > > >> exception of 100 line length. > > >> On Mar 16, 2015 3:27 PM, "Till Rohrmann" <trohrm...@apache.org> > wrote: > > >> > > >> > +1 for stricter Java code styles. I haven't looked into the Google > > Code > > >> > Style but maybe we make it easier for new contributors if we apply a > > >> coding > > >> > style which is somehow known. > > >> > > > >> > +1 for line length of 100 for Scala code. I think it makes code > > review on > > >> > GitHub easier. > > >> > > > >> > For the Scala style, we could stick to official style guidelines > [1]. > > >> > > > >> > [1] http://docs.scala-lang.org/style/ > > >> > > > >> > On Mon, Mar 16, 2015 at 3:06 PM, Hermann Gábor < > reckone...@gmail.com> > > >> > wrote: > > >> > > > >> > > +1 for the stricter Java code styles. > > >> > > > > >> > > We should not forget about providing code formatter settings for > > >> Eclipse > > >> > > and Intellij IDEA (as mentioned above). > > >> > > That would help a lot. > > >> > > > > >> > > (Of course if we'll use Google Code Style, they already provide > such > > >> > files > > >> > > < > > >> > > > > >> > > > >> > > > https://code.google.com/p/google-styleguide/source/browse/trunk/intellij-java-google-style.xml > > >> > > > > > >> > > .) > > >> > > > > >> > > On Mon, Mar 16, 2015 at 2:45 PM Alexander Alexandrov < > > >> > > alexander.s.alexand...@gmail.com> wrote: > > >> > > > > >> > > > +1 for not limiting the line length. > > >> > > > > > >> > > > 2015-03-16 14:39 GMT+01:00 Stephan Ewen <se...@apache.org>: > > >> > > > > > >> > > > > +1 for not limiting the line length. Everyone should have a > good > > >> > sense > > >> > > to > > >> > > > > break lines. When in exceptional cases people violate this, it > > is > > >> > > usually > > >> > > > > for a good reason. > > >> > > > > > > >> > > > > On Mon, Mar 16, 2015 at 2:18 PM, Maximilian Michels < > > >> m...@apache.org> > > >> > > > > wrote: > > >> > > > > > > >> > > > > > +1 for enforcing a more strict Java code style. However, > let's > > >> not > > >> > > > > > introduce a line legth of 100 like in Scala. I think that's > > >> hurting > > >> > > > > > readability of the code. > > >> > > > > > > > >> > > > > > On Sat, Mar 14, 2015 at 4:41 PM, Ufuk Celebi < > u...@apache.org> > > >> > wrote: > > >> > > > > > > > >> > > > > > > On Saturday, March 14, 2015, Aljoscha Krettek < > > >> > aljos...@apache.org > > >> > > > > > >> > > > > > wrote: > > >> > > > > > > > > >> > > > > > > > I'm in favor of strict coding styles. And I like the > > google > > >> > > style. > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > +1 I would like that. We essentially all agree that we > want > > >> more > > >> > > > > > > homogeneity and I think strict rules are the only way to > go. > > >> > Since > > >> > > > this > > >> > > > > > is > > >> > > > > > > a very subjective matter it makes sense to go with > something > > >> > > > (somewhat) > > >> > > > > > > well > > >> > > > > > > established like the Google code style. > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >
