Hi, Kurt Thank you very much for your suggestion. I have studied the design documentation of FLIP-63. I have no comments here. With your suggestion from the previous few days, I am writing a design documentation about the Bucket FileSystem Table Sink and considering how to support the partition. I will send a DISCUSS later,I hope you can help me review it, thank you.
Best Jun ------------------ Original ------------------ From: Kurt Young <ykt...@gmail.com> Date: Sat,Sep 21,2019 11:06 AM To: Jun Zhang <825875...@qq.com> Cc: dev <dev@flink.apache.org> Subject: Re: Add Bucket File System Table Sink Hi Jun, Thanks for your understanding. If we all agree adding this functionality into FLIP-63 is a good idea, I would suggest you also help reviewing the FLIP-63 design document to see if current design meet your requirements. You can also raise some comments to the design document if you have some thoughts. Best, Kurt On Fri, Sep 20, 2019 at 10:44 PM Jun Zhang <825875...@qq.com> wrote: Hi??Fabian ?? Thank you very much for your suggestion. This is when I use flink sql to write data to hdfs at work. I feel that it is inconvenient. I wrote this function, and then I want to contribute it to the community. This is my first PR , some processes may not be clear, I am very sorry. Kurt suggested combining this feature with FLIP-63 because they have some common features, such as write data to file system with kinds of format, so I want to treat this function as a sub-task of FLIP-63. Add a partitionable bucket file system table sink. I then added the document and sent a DISCUSS to explain my detailed design ideas and implementation. How do you see it? ------------------ Original ------------------ From: Fabian Hueske <fhue...@gmail.com> Date: Fri,Sep 20,2019 9:38 PM To: Jun Zhang <825875...@qq.com> Cc: dev <dev@flink.apache.org>, user <u...@flink.apache.org> Subject: Re: Add Bucket File System Table Sink Hi Jun, Thank you very much for your contribution. I think a Bucketing File System Table Sink would be a great addition. Our code contribution guidelines [1] recommend to discuss the design with the community before opening a PR. First of all, this ensures that the design is aligned with Flink's codebase and the future features. Moreover, it helps to find a committer who can help to shepherd the PR. Something that is always a good idea is to split a contribution in multiple smaller PRs (if possible). This allows for faster review and progress. Best, Fabian [1] https://flink.apache.org/contributing/contribute-code.html Am Di., 17. Sept. 2019 um 04:39 Uhr schrieb Jun Zhang <825875...@qq.com>: > Hello everyone: > I am a user and fan of flink. I also want to join the flink community. I > contributed my first PR a few days ago. Can anyone help me to review my > code? If there is something wrong, hope I would be grateful if you can give > some advice. > > This PR is mainly in the process of development, I use sql to read data > from kafka and then write to hdfs, I found that there is no suitable > tablesink, I found the document and found that File System Connector is > only experimental ( > https://ci.apache.org/projects/flink/flink-docs-release-1.9/dev/table/connect.html#file-system-connector), > so I wrote a Bucket File System Table Sink that supports writing stream > data. Hdfs, file file system, data format supports json, csv, parquet, > avro. Subsequently add other format support, such as protobuf, thrift, etc. > > In addition, I also added documentation, python api, units test, > end-end-test, sql-client, DDL, and compiled on travis. > > the issue is https://issues.apache.org/jira/browse/FLINK-12584 > thank you very much > > >
