+1 (non-binding)
- verified signatures and hashsums - started a cluster, ran a socket window word count job, no suspicious log output - tested using SQL Client to submit job and the query result is expected - the web PR looks good Best, Leonard > 在 2021年7月31日，09:08，godfrey he <godfre...@gmail.com> 写道： > > +1 (non-binding) > > - Checked checksums and signatures: OK > - Built from source: OK > - Checked the flink-web PR > - find one typo about the number of the fixes and improvements > - Submit some jobs from sql-client to local cluster, checked the web-ui, > cp, sp, log, etc: OK > > Best, > Godfrey > > > Xingbo Huang <hxbks...@gmail.com> 于2021年7月30日周五 下午2:51写道： > >> +1 (non-binding) >> >> - Verified checksums and signatures >> - Verified Python wheel package contents >> - Pip install apache-flink-libraries source package and apache-flink wheel >> package in Mac >> - Write and Run a Simple Python UDF job in Python REPL >> >> Best, >> Xingbo >> >> Yu Li <car...@gmail.com> 于2021年7月30日周五 下午2:33写道： >> >>> +1 (binding) >>> >>> - Checked the diff between 1.13.1 and 1.13.2-rc3: OK ( >>> >> https://github.com/apache/flink/compare/release-1.13.1...release-1.13.2-rc3 >>> ) >>> - commons-io version has been bumped to 2.8.0 through FLINK-22747 and >> all >>> NOTICE files updated correctly >>> - guava version has been bumped to 29.0 for kinesis connector through >>> FLINK-23009 and all NOTICE files updated correctly >>> - Checked release notes: OK >>> - minor: I've moved FLINK-23315 and FLINK-23418 out of 1.13.2 to keep >>> accordance with RC status >>> - Checked sums and signatures: OK >>> - Maven clean install from source: OK >>> - Checked the jars in the staging repo: OK >>> - Checked the website updates: OK >>> - minor: left some minor comments in PR (such as RN needs update, etc.) >>> and please remember to address them before merging >>> >>> Best Regards, >>> Yu >>> >>> >>> On Fri, 30 Jul 2021 at 14:00, Jingsong Li <jingsongl...@gmail.com> >> wrote: >>> >>>> +1 (non-binding) >>>> >>>> - Check if checksums and GPG files match the corresponding release >> files >>>> - staging repository looks fine >>>> - Start a local cluster (start-cluster.sh), logs fine >>>> - Run sql-client and run a job, looks fine >>>> >>>> I found an unexpected log in sql-client: >>>> "Searching for >>>> >>>> >>> >> '/Users/lijingsong/Downloads/tmp/flink-1.13.2/conf/sql-client-defaults.yaml'...not >>>> found" >>>> This log should be removed. I created a JIRA for this: >>>> https://issues.apache.org/jira/browse/FLINK-23552 >>>> (This should not be a blocker) >>>> >>>> Best, >>>> Jingsong >>>> >>>> On Thu, Jul 29, 2021 at 10:44 PM Robert Metzger <rmetz...@apache.org> >>>> wrote: >>>> >>>>> Thanks a lot for creating this release candidate >>>>> >>>>> +1 (binding) >>>>> >>>>> - staging repository looks fine >>>>> - Diff to 1.13.1 looks fine wrt to dependency changes: >>>>> >>>> >>> >> https://github.com/apache/flink/compare/release-1.13.1...release-1.13.2-rc3 >>>>> - standalone mode works locally >>>>> - I found this issue, which is not specific to 1.13.2: >>>>> https://issues.apache.org/jira/browse/FLINK-23546 >>>>> - src archive signature is matched; sha512 is correct >>>>> >>>>> On Thu, Jul 29, 2021 at 9:10 AM Zakelly Lan <zakelly....@gmail.com> >>>> wrote: >>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> * Built from source. >>>>>> * Run wordcount datastream job on yarn >>>>>> * Web UI and checkpoint seem good. >>>>>> * Kill a container to make job failover, everything is good. >>>>>> * Try run job from checkpoint, everything is good. >>>>>> >>>>>> On Fri, Jul 23, 2021 at 10:04 PM Yun Tang <myas...@live.com> >> wrote: >>>>>> >>>>>>> Hi everyone, >>>>>>> Please review and vote on the release candidate #3 for the >> version >>>>>> 1.13.2, >>>>>>> as follows: >>>>>>> [ ] +1, Approve the release >>>>>>> [ ] -1, Do not approve the release (please provide specific >>> comments) >>>>>>> >>>>>>> >>>>>>> The complete staging area is available for your review, which >>>> includes: >>>>>>> * JIRA release notes [1], >>>>>>> * the official Apache source release and binary convenience >>> releases >>>> to >>>>>> be >>>>>>> deployed to dist.apache.org [2], which are signed with the key >>> with >>>>>>> fingerprint 78A306590F1081CC6794DC7F62DAD618E07CF996 [3], >>>>>>> * all artifacts to be deployed to the Maven Central Repository >> [4], >>>>>>> * source code tag "release-1.13.2-rc3" [5], >>>>>>> * website pull request listing the new release and adding >>>> announcement >>>>>>> blog post [6]. >>>>>>> >>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>> majority >>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>> >>>>>>> Best, >>>>>>> Yun Tang >>>>>>> >>>>>>> [1] >>>>>>> >>>>>> >>>>> >>>> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350218&styleName=&projectId=12315522 >>>>>>> [2] >> https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc3/ >>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>>>> [4] >>>>>>> >>>>> >>> https://repository.apache.org/content/repositories/orgapacheflink-1439/ >>>>>>> [5] >>> https://github.com/apache/flink/releases/tag/release-1.13.2-rc3 >>>>>>> [6] https://github.com/apache/flink-web/pull/453 >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Best, Jingsong Lee >>>> >>> >>
