re: [DISCUSS] Enable scala formatting check

[??????]

+1


I still remember my first pr. Lack of experience, I had to pay attention to 
Scala code format and corrected the format manually, which made me a 
little embarrassed(though I'm a big fan of Scala). I think this proposal 
will lighten the burden of writing Scala code.


Shouwei Liu


------------------ ???????? ------------------
??????:                                                                         
                                               "dev"                            
                                                        <kna...@apache.org&gt;;
????????:&nbsp;2022??3??2??(??????) ????3:01
??????:&nbsp;"dev"<dev@flink.apache.org&gt;;

????:&nbsp;Re: [DISCUSS] Enable scala formatting check



+1 I've never written any Scala in Flink, but this makes a lot of sense to
me. Converging on a smaller set of tools and simplifying the build is
always a good idea and the Community already concluded before that spotless
is generally a good approach.

On Tue, Mar 1, 2022 at 5:52 PM Francesco Guardiani <france...@ververica.com&gt;
wrote:

&gt; Hi all,
&gt;
&gt; I want to propose to enable the spotless scalafmt integration and remove
&gt; the scalastyle plugin.
&gt;
&gt; From an initial analysis, scalafmt can do everything scalastyle can do, and
&gt; the integration with spotless looks easy to enable:
&gt; https://github.com/diffplug/spotless/tree/main/plugin-maven#scala. The
&gt; scalafmt conf file gets picked up automatically from every IDE, and it can
&gt; be heavily tuned.
&gt;
&gt; This way we can unify the formatting and integrate with our CI without any
&gt; additional configurations. And we won't need scalastyle anymore, as
&gt; scalafmt will take care of the checks:
&gt;
&gt; * mvn spotless:check will check both java and scala
&gt; * mvn spotless:apply will format both java and scala
&gt;
&gt; WDYT?
&gt;
&gt; FG
&gt;
&gt;
&gt;
&gt; --
&gt;
&gt; Francesco Guardiani | Software Engineer
&gt;
&gt; france...@ververica.com
&gt;
&gt;
&gt; <https://www.ververica.com/&gt;
&gt;
&gt; Follow us @VervericaData
&gt;
&gt; --
&gt;
&gt; Join Flink Forward <https://flink-forward.org/&gt; - The Apache Flink
&gt; Conference
&gt;
&gt; Stream Processing | Event Driven | Real Time
&gt;
&gt; --
&gt;
&gt; Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany
&gt;
&gt; --
&gt;
&gt; Ververica GmbH
&gt;
&gt; Registered at Amtsgericht Charlottenburg: HRB 158244 B
&gt;
&gt; Managing Directors: Karl Anton Wehner, Holger Temme, Yip Park Tung Jason,
&gt; Jinwei (Kevin) Zhang
&gt;


-- 

Konstantin Knauf

https://twitter.com/snntrable

https://github.com/knaufk