Happy to help get this merged. Do we want to wait until the 1.15 branch is cut? The change is mostly trivial (reformatting) but does make changes to the build system.
Seth On Wed, Mar 9, 2022 at 9:45 AM Francesco Guardiani <france...@ververica.com> wrote: > Hi all, > I've been spending some time prototyping a scalafmt conf, which doesn't > look too different from our java style and tries to keep the same > properties from our scalastyle conf. Here is the PR: > https://github.com/apache/flink/pull/19025 > > In particular, this is the scalafmt config commit: > > https://github.com/apache/flink/pull/19025/commits/cb32893df4b554e4526324c43c86681cc9fe8169 > And this is the commit removing scalastyle: > > https://github.com/apache/flink/pull/19025/commits/9ffe7d52e3368c5c40f15e3dc48f6d81691a8dd0 > > I need some committer to pair with to merge the big PR, any volunteers? :) > > After we merge it I will also update the contributor guide doc to remove > scalastyle. > > FG > > On Tue, Mar 8, 2022 at 10:07 AM David Anderson <dander...@apache.org> > wrote: > > > +1 > > > > For flink-training we initially tried cloning the scalastyle setup from > > flink, but we decided to use spotless + scalafmt instead. > > > > David > > > > On Mon, Mar 7, 2022 at 1:12 PM Timo Walther <twal...@apache.org> wrote: > > > > > Big +1 > > > > > > This will improve the contribution experience. Even though we stopped > > > adding more Scala code, it is still necessary from time to time. > > > > > > Regards, > > > Timo > > > > > > Am 02.03.22 um 09:29 schrieb 刘首维: > > > > +1 > > > > > > > > > > > > I still remember my first pr. Lack of experience, I had to pay > > attention > > > to Scala code format and corrected the format manually, which made me a > > > little embarrassed(though I'm a big fan of Scala). I think this > > > proposal will lighten the burden of writing Scala code. > > > > > > > > > > > > Shouwei Liu > > > > > > > > > > > > ------------------ 原始邮件 ------------------ > > > > 发件人: > > > "dev" > > > < > > > kna...@apache.org>; > > > > 发送时间: 2022年3月2日(星期三) 下午3:01 > > > > 收件人: "dev"<dev@flink.apache.org>; > > > > > > > > 主题: Re: [DISCUSS] Enable scala formatting check > > > > > > > > > > > > > > > > +1 I've never written any Scala in Flink, but this makes a lot of > sense > > > to > > > > me. Converging on a smaller set of tools and simplifying the build is > > > > always a good idea and the Community already concluded before that > > > spotless > > > > is generally a good approach. > > > > > > > > On Tue, Mar 1, 2022 at 5:52 PM Francesco Guardiani < > > > france...@ververica.com> > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > I want to propose to enable the spotless scalafmt integration > and > > > remove > > > > > the scalastyle plugin. > > > > > > > > > > From an initial analysis, scalafmt can do everything scalastyle > > can > > > do, and > > > > > the integration with spotless looks easy to enable: > > > > > > https://github.com/diffplug/spotless/tree/main/plugin-maven#scala > > . > > > The > > > > > scalafmt conf file gets picked up automatically from every IDE, > > and > > > it can > > > > > be heavily tuned. > > > > > > > > > > This way we can unify the formatting and integrate with our CI > > > without any > > > > > additional configurations. And we won't need scalastyle anymore, > > as > > > > > scalafmt will take care of the checks: > > > > > > > > > > * mvn spotless:check will check both java and scala > > > > > * mvn spotless:apply will format both java and scala > > > > > > > > > > WDYT? > > > > > > > > > > FG > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Francesco Guardiani | Software Engineer > > > > > > > > > > france...@ververica.com > > > > > > > > > > > > > > > <https://www.ververica.com/> > > > > > > > > > > Follow us @VervericaData > > > > > > > > > > -- > > > > > > > > > > Join Flink Forward <https://flink-forward.org/> - The Apache > > > Flink > > > > > Conference > > > > > > > > > > Stream Processing | Event Driven | Real Time > > > > > > > > > > -- > > > > > > > > > > Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany > > > > > > > > > > -- > > > > > > > > > > Ververica GmbH > > > > > > > > > > Registered at Amtsgericht Charlottenburg: HRB 158244 B > > > > > > > > > > Managing Directors: Karl Anton Wehner, Holger Temme, Yip Park > Tung > > > Jason, > > > > > Jinwei (Kevin) Zhang > > > > > > > > > > > > > > > > > > > > > >
