Works for me. Feel free to ping me for a review. Best, Matthias
On Wed, Oct 19, 2022 at 10:01 AM Yun Gao <yungao...@aliyun.com.invalid> wrote: > Hi Matthias, > > Thanks a lot for the clarification! If it is not a blocker for 1.16, I > could also continue to > finish the whole work roughly in the next week so we could avoid redundant > work. > Do you think this would be also ok? > > Best, > Yun Gao > > > > > ------------------Original Mail ------------------ > Sender:Matthias Pohl <matthias.p...@aiven.io.INVALID> > Send Date:Wed Oct 19 14:30:45 2022 > Recipients:Flink Dev <dev@flink.apache.org>, Yun Gao <yungao...@aliyun.com > > > Subject:Re: Re: [DISCUSS] Aligning migration test data generation > I don't think that it's actually a blocker for the current release. It's > > more like a nice-to-have. The release managers for 1.16 could still do the > > test data generation manually like you did it for 1.15. So, in this sense, > > we're not under pressure to finalize it before 1.16. > > > > But ok, I will go ahead with my draft PR, then. Could you share a draft PR > > of your efforts to get a better understanding of where you're heading to? > > That might help avoiding redundant work. > > > > On Tue, Oct 18, 2022 at 6:17 PM Yun Gao > > wrote: > > > > > Hi Matthias, > > > I was mainly working on the generator class to automates the process, > > > but sorry I'm bound up with some affairs in this week. Since currently it > > > seems generating the snapshots is a blocker for the releasing, I think > > > one possible > > > way to merge the current efforts are that you continue with the current > > > efforts to > > > simplify the generation process and generating the snapshots first to > > > unblock the > > > release process first, and I'll complete the remaining work to automate > > > the snapshots > > > generating in roughly next week to simplify the future releasing process. > > > Do you think > > > this would work? > > > Best, > > > Yun Gao > > > ------------------------------------------------------------------ > > > From:Matthias Pohl > > > Send Time:2022 Oct. 18 (Tue.) 18:16 > > > To:dev > > > Subject:Re: Re: [DISCUSS] Aligning migration test data generation > > > Thanks for clarifying things and providing the link to the Jira issue. > I'd > > > be curious about the state of your efforts. I'm happy to close my PR if > > > you're saying that your approach is more reasonable or you're almost > done. > > > But we could also merge both efforts. Either way is fine with me. > > > Best, > > > Matthias > > > On Tue, Oct 18, 2022 at 12:00 PM Yun Gao > > > wrote: > > > > Hi Matthias, > > > > > > > > Very thanks for proposing the issue! Currently when releasing a new > > > > version, > > > > it is indeed required to manully generates new test data on the branch > to > > > > release > > > > (namely release-1.16) for all the compatibility tests, and then pick > the > > > > files back to > > > > the master branch so that the files could be used to check the > > > > compatibility during > > > > the development of the next release cycle. > > > > > > > > Currently these tests requires RM to manully uncomment the @Ignore for > > > the > > > > generation > > > > methods and generate the files manually, which is cumbersome and > > > > error-prone. Thus > > > > after releasing 1.15 I have create an issue for modifying these > tests[1], > > > > but very sorry I have > > > > not finished the work yet. > > > > > > > > As a whole, I initially try to create a script to get the above action > > > > done automatically. > > > > I also think we could indeed move the declaration of current version > into > > > > a common place > > > > so that we could modify it unifily, and we could also define a common > > > > structure and file patterns > > > > for the compatibility classes that explicitly defines generators, then > we > > > > could have a class > > > > similar to `ConfigOptionsDocGenerator` to generates all the data, the > > > > script could then pick the > > > > generated files onto the specified branch. > > > > > > > > Best, > > > > Yun Gao > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-27518 < > > > https://issues.apache.org/jira/browse/FLINK-27518 > > > > > > > > > > > > > > > > > > > > > ------------------Original Mail ------------------ > > > > Sender:Matthias Pohl > > > > Send Date:Tue Oct 18 16:35:47 2022 > > > > Recipients:Flink Dev > > > > CC:Yun Gao > > > > Subject:Re: [DISCUSS] Aligning migration test data generation > > > > I created a draft PR to underline my proposal [1]. The PR doesn't cover > > > all > > > > the relevant tests, yet. I'd like to get feedback from anyone who has > > > done > > > > minor releases in the past (CC'ing Yun Gao since he did this task for > > > Flink > > > > 1.15) before proceeding with the tests that are still not migrated > (since > > > > they require a bit more work). > > > > > > > > I'm looking forward to feedback. > > > > Best, > > > > Matthias > > > > > > > > [1] https://github.com/apache/flink/pull/20954 < > > > https://github.com/apache/flink/pull/20954 > > > > > > > > > On Wed, Oct 5, 2022 at 11:42 AM Matthias Pohl > > > > wrote: > > > > > > > > > Hi everyone, > > > > > I started looking into the migration test data generation after I got > > > > > confused about it in the context of the 1.16.0-rc1 voting process > [1]. > > > > The > > > > > release manager needs to do some manual work around adding test data > > > for > > > > > certain tests after the release is finalized (see item 15 in the > > > > "Checklist > > > > > to declare the process completed" section of the documentation for > > > > creating > > > > > a Flink release [2]): > > > > > - Multiple tests need to get an update to the version they run on. > > > > > - Tests will fail due to missing test data. The test data needs to be > > > > > created in a manual process for each of the tests as well. > > > > > > > > > > I'm playing around with aligning this a bit as part of FLINK-29485 > [3]. > > > > > Essentially, I'd like to move the general Flink version range setup > > > into > > > > > flink-test-utils. The release manager would have to update only one > > > > > location instead of each test. > > > > > Additionally, the junit test method implementations responsible for > > > > > generating the test data would be enabled by default. I want to > > > > introduce a > > > > > system property that can be used to specify the Flink version for > which > > > > the > > > > > data shall be generated. We can use assume to enable/disable the test > > > > data > > > > > generation based on this system property. > > > > > > > > > > In the end, the release manager would have to change only code in a > > > > single > > > > > location (instead of multiple files) and run the test suite with this > > > > > system property being set once on the corresponding release branch to > > > > > generate the data. WDYT? I'm curious whether I'm missing something. > > > > > > > > > > Best, > > > > > Matthias > > > > > > > > > > [1] https://lists.apache.org/thread/b0295pq4qpwxg4gpnrr9rjk27zptgkcb > < > > > https://lists.apache.org/thread/b0295pq4qpwxg4gpnrr9rjk27zptgkcb > > > > > > [2] > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > > < > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > > > > > > > > [3] https://issues.apache.org/jira/browse/FLINK-29485 < > > > https://issues.apache.org/jira/browse/FLINK-29485 > > > > > > > > > > > > > > >
