Thanks, Martijn. +1 for releasing a version 3.1 , which only supports Flink 1.18.
Best, Hang Leonard Xu <xbjt...@gmail.com> 于2024年1月26日周五 16:18写道： > Thanks Martijn for driving this. > > +1 to use v3.1 version/branch, we can use v4.0 for Flink minor versions > 1.18&1.19 later. > > > Best, > Leonard > > > > > 2024年1月26日 下午4:13，Martijn Visser <martijnvis...@apache.org> 写道： > > > > Hi! > > > > Thanks for chipping in, clarifying and correcting me. I'll kick off a > release for v3.1 today then! > > > > Best regards, > > > > Martijn > > > > On Fri, Jan 26, 2024 at 8:46 AM Mason Chen <mas.chen6...@gmail.com > <mailto:mas.chen6...@gmail.com>> wrote: > > Hi Martijn, > > > > +1 no objections, thanks for volunteering. I'll definitely help verify > the > > rc when it becomes available. > > > > I think FLIP-288 (I assume you meant this) doesn't introduce incompatible > > changes since the implementation should be state compatible as well as > the > > default changes should be transparent to the user and actually correct > > possibly erroneous behavior. > > > > Also, the RecordEvaluator was released with Flink 1.18 (I assume you > meant > > this). Given the above, I'm +1 for a v3.1 release that only supports 1.18 > > while we support patches on v3.0 that supports 1.17. This logic is also > > inline with what was agreed upon for external connector versioning [1]. > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development > < > https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development > > > > > > Best, > > Mason > > > > On Thu, Jan 25, 2024 at 2:16 PM Martijn Visser <martijnvis...@apache.org > <mailto:martijnvis...@apache.org>> > > wrote: > > > > > Hi everyone, > > > > > > The latest version of the Flink Kafka connector that's available is > > > currently v3.0.2, which is compatible with both Flink 1.17 and Flink > 1.18. > > > > > > I would like to propose to create a release which is either v3.1, or > v4.0 > > > (see below), with compatibility for Flink 1.17 and Flink 1.18. This > newer > > > version would contain many improvements [1] [2] like: > > > > > > * FLIP-246 Dynamic Kafka Source > > > * FLIP-288 Dynamic Partition Discovery > > > * Rack Awareness support > > > * Kafka Record support for KafkaSink > > > * Misc bug fixes and CVE issues > > > > > > If there are no objections, I would like to volunteer as release > manager. > > > > > > The only thing why I'm not sure if this should be a v3.1 or a v4.0, is > > > because I'm not 100% sure if FLIP-246 introduces incompatible API > changes > > > (requiring a new major version), or if the functionality was added in a > > > backwards compatible matter (meaning a new minor version would be > > > sufficient). I'm looping in Hongshun Wang and Leonard Xu to help > clarify > > > this. > > > > > > There's also a discussion happening in an open PR [3] on dropping > support > > > for Flink 1.18 afterwards (since this PR would add support for > > > RecordEvaluator, which only exists in Flink 1.19). My proposal would be > > > that after either v3.1 or v4.0 is released, we would indeed drop > support > > > for Flink 1.18 with that PR and the next Flink Kafka connector would be > > > either v4.0 (if v3.1 is the next release) or v5.0 (if v4.0 is the next > > > release). > > > > > > Best regards, > > > > > > Martijn > > > > > > [1] > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353135 > < > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353135 > > > > > [2] > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352917 > < > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352917 > > > > > [3] > > > > > > > https://github.com/apache/flink-connector-kafka/pull/76#pullrequestreview-1844645464 > < > https://github.com/apache/flink-connector-kafka/pull/76#pullrequestreview-1844645464 > > > > > > >
