+1 (binding) (snuyanzin) Sergey Nuyanzin

+1 (binding)

checked signatures/checksums
built from sources
checked tags
checked LICENSE/NOTICE


however I still have a number of nit-picks

1. There are lots of warnings/annotations in GHA CI [1]
2. ATR does not show java version with what binaries were built
3. ATR does not show type of key used for signing, especially given the fact 
that for some users there are several keys in KEYS file
4. ATR creates a wrong impression that it verifies for signature/checksums 
however this is not true since it does it only for 3 files and didn't do it for 
a bunch of others (for instance [2])

[1] https://github.com/apache/flink-connector-kafka/actions/runs/40353173833
[2] 
https://repository.apache.org/content/repositories/orgapacheflink-1946/org/apache/flink/flink-connector-kafka-python/5.1.0-2.2/

-- 
Sergey Nuyanzin (snuyanzin)

This email was sent by [email protected] on the Apache Trusted Releases 
platform

Reply via email to