If no objections I'd like to merge the update during the afternoon. On Tue, Jan 6, 2015 at 12:32 AM, Márton Balassi <balassi.mar...@gmail.com> wrote:
> Well, cherry-picking was a bit longer than expected, but is finally ready. > [1] > > [1] https://github.com/apache/incubator-flink/pull/282 > > Best, > > Marton > > > On Mon, Jan 5, 2015 at 3:47 PM, Gyula Fóra <gyula.f...@gmail.com> wrote: > >> We don't have any tests for the scala api yet, because in 95% it just >> wraps >> the java api, no new logic except for the aggregations which should have >> tests indeed. The api itself have proper docs we just didn't update the >> streaming-guide. >> >> But I think since the streaming api is still in a beta phase its better to >> have working features out for testing. This speeds up development a lot >> for >> us. >> >> This can be included in the release candidate even today, since its ready. >> >> On Mon, Jan 5, 2015 at 3:36 PM, Robert Metzger <rmetz...@apache.org> >> wrote: >> >> > Do we have any tests for the scala streaming API ? >> > With tests and documentation missing there is very little time. >> > >> > I hope that we get the first release candidate out tomorrow. >> > >> > On Mon, Jan 5, 2015 at 3:33 PM, Gyula Fóra <gyf...@apache.org> wrote: >> > >> > > Yes, we can cherry-pick it, thats not a problem. >> > > >> > > On Mon, Jan 5, 2015 at 3:20 PM, Stephan Ewen <se...@apache.org> >> wrote: >> > > >> > > > Can you cherry-pick it onto the 0.8 branch? >> > > > >> > > > If that works well and the main streaming authors (Marton, Gyula, >> > Paris, >> > > > Jonas, Gabor, ...) back that decision, I would go for it. >> > > > >> > > > On Mon, Jan 5, 2015 at 3:02 PM, Gyula Fóra <gyf...@apache.org> >> wrote: >> > > > >> > > > > +1 >> > > > > I agree to include it, the only thing missing there is the >> streaming >> > > > guide >> > > > > for scala. >> > > > > >> > > > > On Mon, Jan 5, 2015 at 2:49 PM, Paris Carbone <par...@kth.se> >> wrote: >> > > > > >> > > > > > >> > > > > > Hello everyone! >> > > > > > >> > > > > > While the 0.8 release is on its way, I would suggest we also >> > include >> > > > the >> > > > > > latest streaming scala-api. It is fairly stable, at least as >> stable >> > > as >> > > > > the >> > > > > > current java streaming api it builds on and it looks quite >> > > > > straightforward >> > > > > > as well for new users. >> > > > > > >> > > > > > Given that the next release will take a while, we think that it >> > will >> > > be >> > > > > > good to expose the scala api and get some feedback early enough >> so >> > we >> > > > > make >> > > > > > further improvements for the next release. What do you think? >> > > > > > >> > > > > > Paris >> > > > > >> > > > >> > > >> > >> > >
