----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5898/#review9052 -----------------------------------------------------------
Hi Patrik, your code changes seems good to me. Could you also add new section into user guide with your new interceptor? Jarcec - Jarek Cecho On July 11, 2012, 12:53 a.m., Patrick Wendell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5898/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 12:53 a.m.) > > > Review request for Flume. > > > Description > ------- > > Adding a regex-based filtering interceptor > > > This addresses bug FLUME-1358. > https://issues.apache.org/jira/browse/FLUME-1358 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java > 0c112d0 > > flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5898/diff/ > > > Testing > ------- > > Unit tests are included > > > Thanks, > > Patrick Wendell > >
