----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5898/#review9277 -----------------------------------------------------------
Hi Patrick, thank you very much for your time and effort. Code and tests seems good to me, I just have few notes to UserGuide changes: flume-ng-doc/sphinx/FlumeUserGuide.rst <https://reviews.apache.org/r/5898/#comment19886> Tilda characters ("~") are not below entire headline which results in compilation error: System Message: WARNING/2 (/home/jarcec/projects/apache/flume/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1737) Title underline too short. flume-ng-doc/sphinx/FlumeUserGuide.rst <https://reviews.apache.org/r/5898/#comment19887> Could you put "type" property in bold like **type**. Jarcec - Jarek Cecho On July 19, 2012, 2:54 a.m., Patrick Wendell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5898/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 2:54 a.m.) > > > Review request for Flume. > > > Description > ------- > > Adding a regex-based filtering interceptor > > > This addresses bug FLUME-1358. > https://issues.apache.org/jira/browse/FLUME-1358 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java > 0c112d0 > > flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexFilteringInterceptor.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexFilteringInterceptor.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 7967d7c > > Diff: https://reviews.apache.org/r/5898/diff/ > > > Testing > ------- > > Unit tests are included > > > Thanks, > > Patrick Wendell > >
