----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6985/ -----------------------------------------------------------
Review request for Flume. Description ------- Instead of generating ProtoFactory each time we run maven, the class can be generated using: mvn generate-sources -Pcompile-proto This is because we cannot depend on user/build machines having an updated protoc compiler. Diffs ----- flume-ng-channels/flume-file-channel/pom.xml 639195e flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Commit.java 7d57bb8 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java c766d09 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 414d6d9 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Put.java 884ebde flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Rollback.java 1a8ddff flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Take.java cfbe0c9 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/TransactionEventRecord.java f78147f flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/proto/ProtosFactory.java PRE-CREATION flume-ng-channels/flume-file-channel/src/main/proto/filechannel.proto 59dc8db Diff: https://reviews.apache.org/r/6985/diff/ Testing ------- unit tests pass Thanks, Brock Noland
