----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6985/#review11376 -----------------------------------------------------------
Ship it! Oops, didn't publish my comment from yesterday. Oh well it doesn't matter. I agree with what you're saying; we will just need to keep an eye on this since there is an extra semi-automated step involved with making changes to the proto file. Thanks for the explanation Brock! - Mike Percy On Sept. 10, 2012, 8:10 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6985/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 8:10 p.m.) > > > Review request for Flume. > > > Description > ------- > > Instead of generating ProtoFactory each time we run maven, the class can be > generated using: > > mvn generate-sources -Pcompile-proto > > This is because we cannot depend on user/build machines having an updated > protoc compiler. > > > This addresses bug FLUME-1554. > https://issues.apache.org/jira/browse/FLUME-1554 > > > Diffs > ----- > > flume-ng-channels/flume-file-channel/pom.xml 639195e > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Commit.java > 7d57bb8 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java > c766d09 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > 414d6d9 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Put.java > 884ebde > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Rollback.java > 1a8ddff > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Take.java > cfbe0c9 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/TransactionEventRecord.java > f78147f > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/proto/ProtosFactory.java > PRE-CREATION > flume-ng-channels/flume-file-channel/src/main/proto/filechannel.proto > 59dc8db > > Diff: https://reviews.apache.org/r/6985/diff/ > > > Testing > ------- > > unit tests pass > > > Thanks, > > Brock Noland > >
