----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6677/#review11474 -----------------------------------------------------------
Ship it! +1. Looks good. Minor comments inline, a couple unused imports, and one suggestion, which you can ignore if you want. Once these are taken care of, please upload the patch to the jira. flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java <https://reviews.apache.org/r/6677/#comment24572> Unused import. flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java <https://reviews.apache.org/r/6677/#comment24573> Unused import flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java <https://reviews.apache.org/r/6677/#comment24578> You could use the number of processors on the machine as a reasonable default: http://docs.oracle.com/javase/1.4.2/docs/api/java/lang/Runtime.html#availableProcessors() - Hari Shreedharan On Aug. 17, 2012, 12:59 p.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6677/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 12:59 p.m.) > > > Review request for Flume. > > > Description > ------- > > Multi-port capable syslog TCP source. This source can process syslog messages > at around gigabit line speed when used with the memory channel and a > sufficient number of simultaneous client connections. > > > This addresses bug FLUME-1385. > https://issues.apache.org/jira/browse/FLUME-1385 > > > Diffs > ----- > > flume-ng-core/pom.xml 8708953 > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java > 8c87215 > > flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java > PRE-CREATION > pom.xml a277585 > > Diff: https://reviews.apache.org/r/6677/diff/ > > > Testing > ------- > > Added unit tests. Significant manual testing. > > > Thanks, > > Mike Percy > >
