> On Sept. 13, 2012, 5:41 p.m., Hari Shreedharan wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java, > > line 21 > > <https://reviews.apache.org/r/6677/diff/1/?file=142256#file142256line21> > > > > Unused import.
Fixed > On Sept. 13, 2012, 5:41 p.m., Hari Shreedharan wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java, > > line 28 > > <https://reviews.apache.org/r/6677/diff/1/?file=142256#file142256line28> > > > > Unused import Fixed > On Sept. 13, 2012, 5:41 p.m., Hari Shreedharan wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java, > > lines 92-93 > > <https://reviews.apache.org/r/6677/diff/1/?file=142256#file142256line92> > > > > You could use the number of processors on the machine as a reasonable > > default: > > http://docs.oracle.com/javase/1.4.2/docs/api/java/lang/Runtime.html#availableProcessors() Mina takes care of that... the line is in SimpleIoProcessorPool<?>: private static final int DEFAULT_SIZE = Runtime.getRuntime().availableProcessors() + 1; So a default here is not needed. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6677/#review11474 ----------------------------------------------------------- On Aug. 17, 2012, 12:59 p.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6677/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 12:59 p.m.) > > > Review request for Flume. > > > Description > ------- > > Multi-port capable syslog TCP source. This source can process syslog messages > at around gigabit line speed when used with the memory channel and a > sufficient number of simultaneous client connections. > > > This addresses bug FLUME-1385. > https://issues.apache.org/jira/browse/FLUME-1385 > > > Diffs > ----- > > flume-ng-core/pom.xml 8708953 > > flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java > 8c87215 > > flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java > PRE-CREATION > pom.xml a277585 > > Diff: https://reviews.apache.org/r/6677/diff/ > > > Testing > ------- > > Added unit tests. Significant manual testing. > > > Thanks, > > Mike Percy > >
