> On Oct. 8, 2012, 2:20 a.m., Denny Ye wrote: > > That's great to provide extensible Deserializer in graceful method. One tip > > : Could we protect 'ChannelProcessor.processEventBatch' method from > > exception that may be raised at custom Inteceptor or ChannelSelector?
Thanks for the review, Denny! Good point. An exception thrown by the processEventBatch() must result in a failure returned to the client. Will update the patch. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7465/#review12217 ----------------------------------------------------------- On Oct. 7, 2012, 8:22 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7465/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2012, 8:22 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added an HTTP source and a reference deserializer to deserialize events from > json format. > > > This addresses bug FLUME-1199. > https://issues.apache.org/jira/browse/FLUME-1199 > > > Diffs > ----- > > flume-ng-core/pom.xml 4592a9d > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceDeserializer.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/JSONDeserializer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestJSONDeserializer.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 953a670 > pom.xml e19d2d2 > > Diff: https://reviews.apache.org/r/7465/diff/ > > > Testing > ------- > > Added several unit tests. > > > Thanks, > > Hari Shreedharan > >
