> On Oct. 12, 2012, 12:25 a.m., Mike Percy wrote: > > Couple of thoughts: > > 1. HttpResponse gives the plugin writer way too much leeway to write to the > > output stream yet not enough control to do something reliable in the case > > of, say, channel.put() failure. So what we had previously seems preferable > > to this API. > > 2. It would be great if we could provide a JSON interface that looks / > > feels like the Event interface or the AvroFlumeEvent generated class. As > > the patch stands, an Event is represented as a simple map, without > > distinguishing the header map from the body string.
1. Agreed. This is the reason I didn't put in my original patch. I forgot about that when I updated it. 2. It is easy to do this (in fact, easier than the current code). But I am worried about the performance penalty (seems there is a better way than what I thought there was, so I don't expect a major penalty). I am doing some analysis, if it is ok - I will switch to this. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7465/#review12379 ----------------------------------------------------------- On Oct. 9, 2012, 10:44 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7465/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2012, 10:44 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added an HTTP source and a reference deserializer to deserialize events from > json format. > > > This addresses bug FLUME-1199. > https://issues.apache.org/jira/browse/FLUME-1199 > > > Diffs > ----- > > flume-ng-core/pom.xml 4592a9d > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceHandler.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/http/JSONHandler.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletResponseWrapper.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestJSONHandler.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 953a670 > pom.xml e19d2d2 > > Diff: https://reviews.apache.org/r/7465/diff/ > > > Testing > ------- > > Added several unit tests. > > > Thanks, > > Hari Shreedharan > >
