----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7550/#review12372 -----------------------------------------------------------
Hey Brock looks good to me, but I'm a little confused about what Limited Private means. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/7550/#comment26187> Why limted private here? What is the implication? - Mike Percy On Oct. 11, 2012, 6:24 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7550/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2012, 6:24 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add's the Hadoop interface annotations and add's them to a few classes as an > example. Once this approach is agreed upon, any *public* interfaces should be > marked. Private interfaces can be marked in later JIRAs. > > > This addresses bug FLUME-1629. > https://issues.apache.org/jira/browse/FLUME-1629 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 6680a2c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 64725dd > flume-ng-core/src/main/java/org/apache/flume/Channel.java 91ea7b6 > > flume-ng-core/src/main/java/org/apache/flume/annotations/InterfaceAudience.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/annotations/InterfaceStability.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java > e662de9 > > Diff: https://reviews.apache.org/r/7550/diff/ > > > Testing > ------- > > > Thanks, > > Brock Noland > >
