----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7550/#review13167 -----------------------------------------------------------
Ship it! Ship It! - Hari Shreedharan On Oct. 15, 2012, 3:42 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7550/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 3:42 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add's the Hadoop interface annotations and add's them to a few classes as an > example. Once this approach is agreed upon, any *public* interfaces should be > marked. Private interfaces can be marked in later JIRAs. > > > This addresses bug FLUME-1629. > https://issues.apache.org/jira/browse/FLUME-1629 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 6680a2c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 64725dd > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java > bca0c50 > > flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java > 49e7cfd > flume-ng-core/src/main/java/org/apache/flume/Channel.java 91ea7b6 > flume-ng-core/src/main/java/org/apache/flume/NamedComponent.java 1ecb8ea > flume-ng-core/src/main/java/org/apache/flume/Sink.java 2567140 > flume-ng-core/src/main/java/org/apache/flume/Source.java 4697126 > > flume-ng-core/src/main/java/org/apache/flume/annotations/InterfaceAudience.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/annotations/InterfaceStability.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java > e662de9 > > flume-ng-core/src/main/java/org/apache/flume/channel/BasicChannelSemantics.java > ce00d42 > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > fc3a1e2 > flume-ng-core/src/main/java/org/apache/flume/conf/Configurable.java 1d69112 > flume-ng-core/src/main/java/org/apache/flume/interceptor/Interceptor.java > e92e76f > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleAware.java > 0fb82fb > > flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializer.java > 27084dd > flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java 54bf869 > flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java > 861cc42 > > Diff: https://reviews.apache.org/r/7550/diff/ > > > Testing > ------- > > > Thanks, > > Brock Noland > >
