----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7465/#review12549 -----------------------------------------------------------
Ship it! +1 lgtm I am going to manually fix the doc issue mentioned below before I commit. A couple things that I don't think are blockers, but that I'd like to see in a followup JIRA: 1. Always return a SimpleEvent from the JSON handler, since it will have predictable and consistent performance characteristics 2. Never allow a state where the event body is null. If it's null, just allocate a new byte[0] ... allowing that can trip up serialization code. flume-ng-core/src/main/java/org/apache/flume/source/http/JSONHandler.java <https://reviews.apache.org/r/7465/#comment26719> Minor doc quibble: should read something like (a:b, c:d). I can fix this myself though - Mike Percy On Oct. 17, 2012, 5:56 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7465/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2012, 5:56 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added an HTTP source and a reference deserializer to deserialize events from > json format. > > > This addresses bug FLUME-1199. > https://issues.apache.org/jira/browse/FLUME-1199 > > > Diffs > ----- > > flume-ng-core/pom.xml 5c94264 > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPBadRequestException.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceHandler.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/http/JSONHandler.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestJSONHandler.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst e5f7581 > flume-ng-sdk/src/main/java/org/apache/flume/event/JSONEvent.java > PRE-CREATION > pom.xml 4cd4009 > > Diff: https://reviews.apache.org/r/7465/diff/ > > > Testing > ------- > > Added several unit tests. > > > Thanks, > > Hari Shreedharan > >
