[ 
https://issues.apache.org/jira/browse/FLUME-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483430#comment-13483430
 ] 

Hari Shreedharan edited comment on FLUME-1645 at 10/24/12 6:08 PM:
-------------------------------------------------------------------

Yes, you are right - everyone may not want the "." in the filename. It should 
not be inserted automatically by us. I just thought you missed it - my bad ;)

I think this patch is ready to go, but I'd like to see:
1. The parameter added to the documentation - clearly specify that there is no 
"." added, so suffix should be ".avro" if that is needed. You can add this to 
flume-ng-doc/sphinx/FlumeUserGuide.rst
2. A unit test. I know bunch of the original stuff didn't have unit tests, but 
it is best to add unit tests for as much new stuff as possible. 
                
      was (Author: hshreedharan):
    Agreed, you can make the "." optional. I just thought you missed it ;)

I think this patch is ready to go, but I'd like to see:
1. The parameter added to the documentation - clearly specify that there is no 
"." added, so suffix should be ".avro" if that is needed. You can add this to 
flume-ng-doc/sphinx/FlumeUserGuide.rst
2. A unit test. I know bunch of the original stuff didn't have unit tests, but 
it is best to add unit tests for as much new stuff as possible. 
                  
> add hdfs.fileSuffix property to HDFSEventSink
> ---------------------------------------------
>
>                 Key: FLUME-1645
>                 URL: https://issues.apache.org/jira/browse/FLUME-1645
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.2.0
>            Reporter: Steve Hoffman
>         Attachments: patch.diff
>
>
> I'd like to be able to use Avro files created by flume as input to a 
> MapReduce job.  However, the AvroInputFormat requires that avro files end in 
> .avro and there appears to be no property on the hdfs sink that allows me to 
> set a suffix (default being blank, of course).
> Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to