----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8087/#review13525 -----------------------------------------------------------
why not simplify it to .. // delete log.meta // log.meta.tmp -> log.meta - Roshan Naik On Nov. 16, 2012, 7:26 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8087/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 7:26 p.m.) > > > Review request for Flume. > > > Description > ------- > > If atomic rename fails, rename the current meta file to old, rename tmp to > meta and then delete old. > > > This addresses bug FLUME-1699. > https://issues.apache.org/jira/browse/FLUME-1699 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > f768d23 > > Diff: https://reviews.apache.org/r/8087/diff/ > > > Testing > ------- > > All unit tests pass > > > Thanks, > > Hari Shreedharan > >
