----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8087/#review13576 -----------------------------------------------------------
Looks quite good. Just one issue below flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java <https://reviews.apache.org/r/8087/#comment29140> If either of these renames fail, we have set the hasMeta flag to true but no .meta file exists. - Brock Noland On Nov. 19, 2012, 4:53 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8087/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2012, 4:53 a.m.) > > > Review request for Flume and Brock Noland. > > > Description > ------- > > If atomic rename fails, rename the current meta file to old, rename tmp to > meta and then delete old. > > > This addresses bug FLUME-1699. > https://issues.apache.org/jira/browse/FLUME-1699 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java > 82e14b0 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > f768d23 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java > 6b0eeb3 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java > 4b69698 > > Diff: https://reviews.apache.org/r/8087/diff/ > > > Testing > ------- > > All unit tests pass > > > Thanks, > > Hari Shreedharan > >
