Might I humbly ask for review & commit FLUME-1719 for next RC?
Jarcec
On Sat, Nov 17, 2012 at 07:13:26PM -0800, Hari Shreedharan wrote:
Done! Thanks Mike, Brock!
Hari
--
Hari Shreedharan
On Saturday, November 17, 2012 at 7:05 PM, Brock Noland wrote:
Ok, let's do another rc since the same lobs with different versions is
probably bad.
Also I think it's fine to commit to 1.3 without another rc since we
are voting on a tag, not the branch.
--
Brock Noland
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Saturday, November 17, 2012 at 8:45 PM, Mike Percy wrote:
Hari,
You're correct that a -1 vote does not veto a release. A savvy user
could
delete one of the jars before deploying to production, but why make
them do
that.
Thanks for the commit.
Regards,
Mike
On Sat, Nov 17, 2012 at 6:12 PM, Hari Shreedharan <
hshreedha...@cloudera.com (mailto:hshreedha...@cloudera.com)
wrote:
Mike,
I committed your patch for flume-1.4, and trunk.
Brock: As I posted on the jira, if you want it committed to
flume-1.3. the
RM should decide if another RC is required (looks like there are 3
PMC +1
already, unless someone withdraws the +1). If required, please
cherry-pick
the patch to flume-1.3.0 and roll another RC.
Thanks,
Hari
--
Hari Shreedharan
On Saturday, November 17, 2012 at 5:58 PM, Mike Percy wrote:
When I was reviewing the libs I noticed that netty is in there
twice
with 2
different versions. I don't think we should ship like that.
So, -1 from me on this RC.
Details and a patch are here:
https://issues.apache.org/jira/browse/FLUME-1723
Regards,
Mike
On Sat, Nov 17, 2012 at 3:33 PM, Brock Noland <
br...@cloudera.com (mailto:br...@cloudera.com)(mailto:
br...@cloudera.com (mailto:br...@cloudera.com))> wrote:
Thanks Hari, I have created FLUME-1722 for this purpose.
https://issues.apache.org/jira/browse/FLUME-1722
Brock
On Sat, Nov 17, 2012 at 5:29 PM, Hari Shreedharan
<hshreedha...@cloudera.com (mailto:hshreedha...@cloudera.com)>
wrote:
+1.
Here is what I checked:
1. Checksums and signatures look good.
2. Verified license file, readme, change log and notice file
(more on
this below).
3. Built, ran unit tests, ran an agent with the sample
config - looks
good.
Additional notes:
The LICENSE file seems to list three libraries which we do
not pull
in:
commons logging
http-client
http-core
We probably should remove these from the license file too.
Thanks,
Hari
--
Hari Shreedharan
On Saturday, November 17, 2012 at 12:57 AM, Alexander
Alten-Lorenz
wrote:
+1
- Alex
On Nov 17, 2012, at 4:10 AM, Will McQueen <
w...@cloudera.com (mailto:w...@cloudera.com)(mailto:
w...@cloudera.com (mailto:w...@cloudera.com)) (mailto:
w...@cloudera.com (mailto:w...@cloudera.com))> wrote:
+1 on the release
On Nov 16, 2012, at 6:56 PM, Brock Noland <
br...@cloudera.com (mailto:br...@cloudera.com)(mailto:
br...@cloudera.com (mailto:br...@cloudera.com))(mailto:
br...@cloudera.com (mailto:br...@cloudera.com))> wrote:
Thanks Jarek, I don't think it's a blocker but we
should
definitely
fix it.
FWIW, hadoop's LICENSE.txt doesn't even list the
licenses of
binaries
and Crunch was just released with many defects to this
file.
On Fri, Nov 16, 2012 at 8:42 PM, Jarek Jarcec Cecho <
jar...@apache.org (mailto:jar...@apache.org)> wrote:
I've noticed that LICENSE file contains entry
protobuf-<version>.jar whereas our binary artifacts seems to
be pulling
protobuf-java-<version>.jar (filled FLUME-1720 [1]). It do
need seems
as a
blocker to me, but it would be great if someone else with more
deeper
licensing knowledge would confirm that. As long as this is
fine, I'm
+1 on
the release.
Checked:
* Checksums, signatures seems fine
* "mvn clean compile test verify package" passes for
source
artifact
* "mvn verify" passes for binary artifact
* CHANGELOG, NOTICE, README, DEVNOTES files seems
fine to me
Notes:
* Filled FLUME-1719: Example export command in
README do not
properly close the string
* Filled FLUME-1720: LICENSE file contain entry for
protobuf-<version>.jar, however proper artifact name is
protobuf-java-<version>.jar
Jarcec
Links:
1: https://issues.apache.org/jira/browse/FLUME-1720
On Fri, Nov 16, 2012 at 07:49:13AM +0100, Alexander
Alten-Lorenz
wrote:
looks good to me, thanks.
+1
cheers,
Alex
On Nov 16, 2012, at 12:21 AM, Brock Noland <
br...@cloudera.com (mailto:br...@cloudera.com)(mailto:
br...@cloudera.com (mailto:br...@cloudera.com))> wrote:
+1 verified sigs, hashes, built docs, and
verified smoke
test
On Thu, Nov 15, 2012 at 5:16 PM, Brock Noland <
br...@cloudera.com (mailto:br...@cloudera.com)> wrote:
This is the second release for Apache Flume as
a
top-level
project,
version 1.3.0. We are voting on release
candidate rc3.
*** Please cast your vote within the next 72
hours ***
The list of fixed issues:
https://git-wip-us.apache.org/repos/asf?p=flume.git;a=blob_plain;f=CHANGELOG;hb=656e049981df62316e0a817382087297209bf2f3
The tarball (*.tar.gz), signature (*.asc), and
checksums
(*.md5, *.sha1)
for the source and binary artifacts can be
found at:
http://people.apache.org/~brock/flume-1.3.0-rc3/
(Note: attempting to deploy the artifacts to
Nexus
appears
to have
locked me out of Apache LDAP so you'll have to
use the
artifacts from
the above link or via the source tag below.)
The tag to be voted on:
https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=656e049981df62316e0a817382087297209bf2f3
The KEYS file can be found here:
https://dist.apache.org/repos/dist/release/flume/KEYS
--
Apache MRUnit - Unit testing MapReduce -
http://incubator.apache.org/mrunit/
--
Alexander Alten-Lorenz
http://mapredit.blogspot.com
German Hadoop LinkedIn Group: http://goo.gl/N8pCF
--
Apache MRUnit - Unit testing MapReduce -
http://incubator.apache.org/mrunit/
--
Alexander Alten-Lorenz
http://mapredit.blogspot.com
German Hadoop LinkedIn Group: http://goo.gl/N8pCF
--
Apache MRUnit - Unit testing MapReduce -
http://incubator.apache.org/mrunit/
