> On Dec. 10, 2012, 7:45 p.m., Hari Shreedharan wrote: > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java, > > lines 65-68 > > <https://reviews.apache.org/r/8328/diff/2/?file=235858#file235858line65> > > > > Why make this package private? > > Brock Noland wrote: > Hi, > > Just curious, is this the only thing holding this patch up? > > Hari Shreedharan wrote: > I was expecting the contributor to come back with this change. Since he > has not, I think we can commit this. I'd like to review this once more and > commit this. > > Hari Shreedharan wrote: > I am going to make this change and commit this. > > Hari Shreedharan wrote: > The tests added are failing too. > > Cameron Gandevia wrote: > Sorry guys I was out of town during the holidays. I have fixed the test > cases. > > The RpcClient is now instantiated in the LoadBalancingLog4jAppender a > subclass of the Log4jAppender which is why I made the access change.
Thanks Cameron. Let me try running the tests with the new patch. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8328/#review14257 ----------------------------------------------------------- On Jan. 18, 2013, 2:17 a.m., Cameron Gandevia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8328/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2013, 2:17 a.m.) > > > Review request for Flume. > > > Description > ------- > > The Log4jAppender should be extended to use the LoadBalancingRpcClient > allowing users to configure a load balancing log4jappender > > > Diffs > ----- > > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java > 315a68c > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java.orig > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974 > > Diff: https://reviews.apache.org/r/8328/diff/ > > > Testing > ------- > > > Thanks, > > Cameron Gandevia > >
