----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8328/#review15606 -----------------------------------------------------------
Ship it! Looks good, great patch! Could you please remove the whitespaces and attach the patch to the jira so I can commit it? Thanks! flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java <https://reviews.apache.org/r/8328/#comment33702> Nit: Whitespaces. - Hari Shreedharan On Jan. 22, 2013, 10:09 p.m., Cameron Gandevia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8328/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 10:09 p.m.) > > > Review request for Flume. > > > Description > ------- > > The Log4jAppender should be extended to use the LoadBalancingRpcClient > allowing users to configure a load balancing log4jappender > > > Diffs > ----- > > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java > 315a68c > > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties > PRE-CREATION > > flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974 > > Diff: https://reviews.apache.org/r/8328/diff/ > > > Testing > ------- > > > Thanks, > > Cameron Gandevia > >
