> On March 14, 2013, 6:53 a.m., Alexander Alten-Lorenz wrote: > > What do your think to rename MultilineBody into SyslogMultiLineBody? > > Ambud Sharma wrote: > I have changed the variable and constant names accordingly. Please let me > know if the patch looks ok now? > > Als, do I need to provide a corresponding "config" document for setting > the multi-line property true in flume.conf?
Yes, please update the config section in our documentation. The patch looks okay (for me). Thanks for your effort! I'll review when the doc part is done too ;) - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review17861 ----------------------------------------------------------- On March 14, 2013, 7:14 a.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 7:14 a.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java > 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java > c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java > 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/ > > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
