----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9842/#review21613 -----------------------------------------------------------
Ship it! Thanks for finding and fixing the SyslogTCP issue. Looks good to me. - Alexander Alten-Lorenz On June 3, 2013, 9:41 p.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9842/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 9:41 p.m.) > > > Review request for Flume. > > > Description > ------- > > Ref: https://issues.apache.org/jira/browse/FLUME-1938 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogSourceConfigurationConstants.java > 5a73c88 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 96a9e85 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java > c2a29a1 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java > 7208464 > > Diff: https://reviews.apache.org/r/9842/diff/ > > > Testing > ------- > > Functional test done resulting in full message body being written to file. > > > Thanks, > > Ambud Sharma > >
