----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8899/#review17888 -----------------------------------------------------------
Thanks for the review, Brock! I will submit an updated patch soon. Thanks! flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37865> Yes, Will do. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37866> Will update in next patch with a !null if condition flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37867> The reason there is a backupComplete file is to ensure that we know that all files were copied. The idea is that if we were in the middle of copying (only some files were copied, not all), then this indicates the copying was incomplete. This would be for the case where the checkpoint is somehow corrupt and we try to retrieve the backup - at that point, we need to be sure the backup actually contains all files required (this makes it extensible, in case we add more files to the checkpoint) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37869> will fix flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37871> will add check flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37872> The previous backup is still happening, so we skip this checkpoint, rather than trying to abort the backup, cleanup the previous one and start the checkpoint. (If the checkpoint interval is too low, then there may never be a backup if we do that) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37873> Agreed flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment37874> will do flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/8899/#comment37875> This was done to get the IDE to shut up ;) flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/8899/#comment37876> Yeah, this was just me being lazy :P flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/8899/#comment37877> yeah, I think we should flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/8899/#comment37878> might make sense to do so. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java <https://reviews.apache.org/r/8899/#comment37879> yeah, this one confuses a lot of people! flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java <https://reviews.apache.org/r/8899/#comment37880> will do - Hari Shreedharan On March 14, 2013, 7:31 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8899/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 7:31 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added support for backup and retrieval of checkpoint. > > > This addresses bug FLUME-1516. > https://issues.apache.org/jira/browse/FLUME-1516 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java > b136eb0 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java > a19bdb4 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 4115505 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java > 451a9d4 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > ff42d19 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 24368b3 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > 1ed9547 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 6ffc824 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1db3717 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > f51935c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java > fa4fd9d > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java > 7094d3c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/proto/ProtosFactory.java > e6d4957 > flume-ng-channels/flume-file-channel/src/main/proto/filechannel.proto > 3a4e828 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java > 3da09ab > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java > 170dc72 > > Diff: https://reviews.apache.org/r/8899/diff/ > > > Testing > ------- > > Added new unit tests. Current tests pass. > > > Thanks, > > Hari Shreedharan > >
