----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8899/#review18364 -----------------------------------------------------------
Another round of items. Have you done any manual testing of this patch? flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment38570> Unless there is a reason to use getCanonicalPath, which throws an IOException, might as well just use the toString(). flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment38565> If listFiles() returns null, we say later the checkpoint was successful when it was not. I think we should throw an exception. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment38566> What buffer size is used for this copy? flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment38564> Same as backupExists? flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment38563> What kind of buffer size are we using during this copy? flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/8899/#comment38568> As opposed to this, how about using drainPermits(). Then if we ever return > 1, throw an illegal state exception. This ensures we are using the semaphore correctly. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java <https://reviews.apache.org/r/8899/#comment38562> This is a misconfiguration. I think we should throw an exception as opposed to ignoring this. - Brock Noland On March 25, 2013, 9:03 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8899/ > ----------------------------------------------------------- > > (Updated March 25, 2013, 9:03 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added support for backup and retrieval of checkpoint. > > > This addresses bug FLUME-1516. > https://issues.apache.org/jira/browse/FLUME-1516 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java > b136eb0 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java > a19bdb4 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 4115505 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java > 451a9d4 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > ff42d19 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 24368b3 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > 1ed9547 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 6ffc824 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1db3717 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > f51935c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java > fa4fd9d > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java > 7094d3c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/proto/ProtosFactory.java > e6d4957 > flume-ng-channels/flume-file-channel/src/main/proto/filechannel.proto > 3a4e828 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java > 3da09ab > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java > 170dc72 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java > ba653e6 > > Diff: https://reviews.apache.org/r/8899/diff/ > > > Testing > ------- > > Added new unit tests. Current tests pass. > > > Thanks, > > Hari Shreedharan > >
