-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10416/#review19246
-----------------------------------------------------------
Looks good overall. However I think there is an issue where there are certain
assumptions made about keys existing when they may not be set.
I am getting a NullPointerException at stop() time (when I kill Flume via
Ctrl-C) when running with this config file:
agent.sources = seqGenSrc
agent.channels = memoryChannel
agent.sinks = nullSink
agent.channels.memoryChannel.type = memory
agent.channels.memoryChannel.capacity = 100
agent.sources.seqGenSrc.type = seq
agent.sources.seqGenSrc.channels = memoryChannel
agent.sinks.nullSink.type = null
agent.sinks.nullSink.channel = memoryChannel
I tweaked the patch a little to validate (basically using
Preconditions.checkNotNull(counterMap.get(counter), ...)) to get a helpful
error message for this and I see the following:
Exception in thread "agent-shutdown-hook" java.lang.NullPointerException:
Unknown counter: channel.start.time
at
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:204)
at
org.apache.flume.instrumentation.MonitoredCounterGroup.get(MonitoredCounterGroup.java:192)
at
org.apache.flume.instrumentation.MonitoredCounterGroup.stop(MonitoredCounterGroup.java:153)
at org.apache.flume.channel.MemoryChannel.stop(MemoryChannel.java:355)
at
org.apache.flume.lifecycle.LifecycleSupervisor.stop(LifecycleSupervisor.java:106)
at org.apache.flume.node.Application.stop(Application.java:92)
at org.apache.flume.node.Application$1.run(Application.java:302)
- Mike Percy
On April 11, 2013, 4:44 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10416/
> -----------------------------------------------------------
>
> (Updated April 11, 2013, 4:44 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logging Metrics from the stop() method for the following components:
> ChannelCounter, ChannelProcessorCounter, SinkCounter, SinkProcessorCounter,
> SourceCounter
>
>
> This addresses bugs FLUME-1940 and FLUME-1957.
> https://issues.apache.org/jira/browse/FLUME-1940
> https://issues.apache.org/jira/browse/FLUME-1957
>
>
> Diffs
> -----
>
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java
> 502fe9e
>
> Diff: https://reviews.apache.org/r/10416/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Israel Ekpo
>
>
