----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10416/#review19250 -----------------------------------------------------------
I think instead of adding the start and stop times for the components in the map I will just dump them separately and then proceed with sorting the orignal keys in the map only. I will also add a check to make sure the value exists as you recommended. Thanks for the feedback. - Israel Ekpo On April 11, 2013, 4:44 a.m., Israel Ekpo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10416/ > ----------------------------------------------------------- > > (Updated April 11, 2013, 4:44 a.m.) > > > Review request for Flume. > > > Description > ------- > > Logging Metrics from the stop() method for the following components: > ChannelCounter, ChannelProcessorCounter, SinkCounter, SinkProcessorCounter, > SourceCounter > > > This addresses bugs FLUME-1940 and FLUME-1957. > https://issues.apache.org/jira/browse/FLUME-1940 > https://issues.apache.org/jira/browse/FLUME-1957 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/MonitoredCounterGroup.java > 502fe9e > > Diff: https://reviews.apache.org/r/10416/diff/ > > > Testing > ------- > > > Thanks, > > Israel Ekpo > >
