----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15110/#review27862 -----------------------------------------------------------
A better solution would be to have this class inherit the class that implements this (where this class was moved to). In that case this is guaranteed to be backward compatible too. flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobDeserializer.java <https://reviews.apache.org/r/15110/#comment54265> This is backwards incompatible. You cannot change the interfaces implemented by the class. I suspect this will break the spool dir source if you use this. flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobDeserializer.java <https://reviews.apache.org/r/15110/#comment54267> This code too is a bit of a problem: Any code that looks like this would fail: org.apache.flume.sink.solr.morphline.BlobSerializer s = BlobSerializer.Builder.build(); Though we don't have any classes that do that this will be a problem. - Hari Shreedharan On Oct. 31, 2013, 12:52 a.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15110/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 12:52 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2227 > https://issues.apache.org/jira/browse/FLUME-2227 > > > Repository: flume-git > > > Description > ------- > > - Moved BlobDeserializer out of morphline sink and into > core/.../serialization along with tests. > - Updated docs to reflect new FQCN > - Retained dummy class for old FQCN compat > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/serialization/BlobDeserializer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestByteInputStream.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestBlobDeserializer.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst e38bb67 > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobDeserializer.java > 12bdc40 > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/ResettableTestStringInputStream.java > e6ee9b9 > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobDeserializer.java > 6172c68 > > Diff: https://reviews.apache.org/r/15110/diff/ > > > Testing > ------- > > unit tests > > > Thanks, > > Roshan Naik > >
