> On Nov. 4, 2013, 8:22 p.m., Wolfgang Hoschek wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1988 > > <https://reviews.apache.org/r/15110/diff/1-2/?file=374542#file374542line1988> > > > > ES changes should be moved into a separate JIRA as they are unrelated.
Something weird here. Actually these changes are not part of my patch. it seems to be showing up when you diff v1 and v2 patches for some reason. If you click directly on view diff, you will see it is not there. > On Nov. 4, 2013, 8:22 p.m., Wolfgang Hoschek wrote: > > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 2009 > > <https://reviews.apache.org/r/15110/diff/1-2/?file=374542#file374542line2009> > > > > ES changes should be moved into a separate JIRA as they are unrelated. again.. not in the patch. - Roshan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15110/#review28133 ----------------------------------------------------------- On Nov. 1, 2013, 12:35 a.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15110/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 12:35 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2227 > https://issues.apache.org/jira/browse/FLUME-2227 > > > Repository: flume-git > > > Description > ------- > > - Moved BlobDeserializer out of morphline sink and into > core/.../serialization along with tests. > - Updated docs to reflect new FQCN > - Retained dummy class for old FQCN compat > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/serialization/BlobDeserializer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestByteInputStream.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestBlobDeserializer.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst 3a3038c > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobDeserializer.java > 12bdc40 > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/ResettableTestStringInputStream.java > e6ee9b9 > > flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobDeserializer.java > 6172c68 > > Diff: https://reviews.apache.org/r/15110/diff/ > > > Testing > ------- > > unit tests > > > Thanks, > > Roshan Naik > >
